diff mbox

[v2] drm/tegra: Setup PHY_TIMING & BTA_TIMING registers in setup_clock()

Message ID 1412004798-18233-1-git-send-email-seanpaul@chromium.org
State Accepted, archived
Headers show

Commit Message

Sean Paul Sept. 29, 2014, 3:33 p.m. UTC 
Make sure we initialize the dsi PHY_TIMING and BTA_TIMING registers
when we setup the clocks. If left uninitialized, they can cause DCS
transfers to fail.

Signed-off-by: Sean Paul <seanpaul@chromium.org>
---

Changes in v2:
	- Removed the recursive slave call in set_phy_timing, this will need
	  to be applied once ganging is applied

 drivers/gpu/drm/tegra/dsi.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
diff mbox

Patch

diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c
index f787445..b87b5a4 100644
--- a/drivers/gpu/drm/tegra/dsi.c
+++ b/drivers/gpu/drm/tegra/dsi.c
@@ -482,10 +482,6 @@  static int tegra_output_dsi_enable(struct tegra_output *output)
 	value &= ~DSI_CONTROL_HOST_ENABLE;
 	tegra_dsi_writel(dsi, value, DSI_CONTROL);
 
-	err = tegra_dsi_set_phy_timing(dsi);
-	if (err < 0)
-		return err;
-
 	for (i = 0; i < NUM_PKT_SEQ; i++)
 		tegra_dsi_writel(dsi, pkt_seq[i], DSI_PKT_SEQ_0_LO + i);
 
@@ -660,6 +656,12 @@  static int tegra_output_dsi_setup_clock(struct tegra_output *output,
 	value = DSI_TALLY_TA(0) | DSI_TALLY_LRX(0) | DSI_TALLY_HTX(0);
 	tegra_dsi_writel(dsi, value, DSI_TO_TALLY);
 
+	err = tegra_dsi_set_phy_timing(dsi);
+	if (err) {
+		dev_err(dsi->dev, "failed to setup phy timing: %d\n", err);
+		return err;
+	}
+
 	return 0;
 }