diff mbox

[iproute2-next] ss: output dctcp diag information

Message ID 1411980452-4669-1-git-send-email-dborkman@redhat.com
State Accepted, archived
Delegated to: stephen hemminger
Headers show

Commit Message

Daniel Borkmann Sept. 29, 2014, 8:47 a.m. UTC 
Dump useful DCTCP state/debug information gathered from diag.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
---
 include/linux/inet_diag.h | 13 +++++++++++--
 misc/ss.c                 | 13 +++++++++++++
 2 files changed, 24 insertions(+), 2 deletions(-)

Comments

Stephen Hemminger Oct. 30, 2014, 5:53 a.m. UTC | #1 
On Mon, 29 Sep 2014 10:47:32 +0200
Daniel Borkmann <dborkman@redhat.com> wrote:

> Dump useful DCTCP state/debug information gathered from diag.
> 
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> Signed-off-by: Florian Westphal <fw@strlen.de>

Applied, I had already got the header files from regular kernel headers update.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/linux/inet_diag.h b/include/linux/inet_diag.h
index e34f247..7438dad 100644
--- a/include/linux/inet_diag.h
+++ b/include/linux/inet_diag.h
@@ -110,10 +110,10 @@  enum {
 	INET_DIAG_TCLASS,
 	INET_DIAG_SKMEMINFO,
 	INET_DIAG_SHUTDOWN,
+	INET_DIAG_DCTCPINFO,
 };
 
-#define INET_DIAG_MAX INET_DIAG_SHUTDOWN
-
+#define INET_DIAG_MAX INET_DIAG_DCTCPINFO
 
 /* INET_DIAG_MEM */
 
@@ -133,5 +133,14 @@  struct tcpvegas_info {
 	__u32	tcpv_minrtt;
 };
 
+/* INET_DIAG_DCTCPINFO */
+
+struct tcp_dctcp_info {
+	__u16	dctcp_enabled;
+	__u16	dctcp_ce_state;
+	__u32	dctcp_alpha;
+	__u32	dctcp_ab_ecn;
+	__u32	dctcp_ab_tot;
+};
 
 #endif /* _INET_DIAG_H_ */
diff --git a/misc/ss.c b/misc/ss.c
index c847954..f5019e1 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -1576,6 +1576,19 @@  static void tcp_show_info(const struct nlmsghdr *nlh, struct inet_diag_msg *r,
 				rtt =  vinfo->tcpv_rtt;
 		}
 
+		if (tb[INET_DIAG_DCTCPINFO]) {
+			const struct tcp_dctcp_info *dinfo
+				= RTA_DATA(tb[INET_DIAG_DCTCPINFO]);
+
+			if (dinfo->dctcp_enabled) {
+				printf(" ce_state %u alpha %u ab_ecn %u ab_tot %u",
+				       dinfo->dctcp_ce_state, dinfo->dctcp_alpha,
+				       dinfo->dctcp_ab_ecn, dinfo->dctcp_ab_tot);
+			} else {
+				printf(" fallback_mode");
+			}
+		}
+
 		if (rtt > 0 && info->tcpi_snd_mss && info->tcpi_snd_cwnd) {
 			printf(" send %sbps",
 			       sprint_bw(b1, (double) info->tcpi_snd_cwnd *