| Message ID | 1411955914-550-1-git-send-email-lixi@ddn.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 9/28/14 8:58 PM, Li Xi wrote: > When ext4_do_update_inode() gets error from ext4_inode_blocks_set(), > error number should be returned. How strange, it has been missing this error return ever since the original commit in 2008. :) Reviewed-by: Eric Sandeen <sandeen@redhat.com> > Signed-off-by: Li Xi <lixi@ddn.com> > --- > fs/ext4/inode.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index d5dd7d4..03ddfd7 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -4204,7 +4204,8 @@ static int ext4_do_update_inode(handle_t *handle, > EXT4_INODE_SET_XTIME(i_atime, inode, raw_inode); > EXT4_EINODE_SET_XTIME(i_crtime, ei, raw_inode); > > - if (ext4_inode_blocks_set(handle, raw_inode, ei)) { > + err = ext4_inode_blocks_set(handle, raw_inode, ei); > + if (err) { > spin_unlock(&ei->i_raw_lock); > goto out_brelse; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon 29-09-14 09:58:34, Li Xi wrote: > When ext4_do_update_inode() gets error from ext4_inode_blocks_set(), > error number should be returned. Looks good. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > > Signed-off-by: Li Xi <lixi@ddn.com> > --- > fs/ext4/inode.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index d5dd7d4..03ddfd7 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -4204,7 +4204,8 @@ static int ext4_do_update_inode(handle_t *handle, > EXT4_INODE_SET_XTIME(i_atime, inode, raw_inode); > EXT4_EINODE_SET_XTIME(i_crtime, ei, raw_inode); > > - if (ext4_inode_blocks_set(handle, raw_inode, ei)) { > + err = ext4_inode_blocks_set(handle, raw_inode, ei); > + if (err) { > spin_unlock(&ei->i_raw_lock); > goto out_brelse; > } > -- > 1.7.1 >
On Mon, Sep 29, 2014 at 09:58:34AM +0800, Li Xi wrote: > When ext4_do_update_inode() gets error from ext4_inode_blocks_set(), > error number should be returned. > > Signed-off-by: Li Xi <lixi@ddn.com> Applied, thanks. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index d5dd7d4..03ddfd7 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -4204,7 +4204,8 @@ static int ext4_do_update_inode(handle_t *handle, EXT4_INODE_SET_XTIME(i_atime, inode, raw_inode); EXT4_EINODE_SET_XTIME(i_crtime, ei, raw_inode); - if (ext4_inode_blocks_set(handle, raw_inode, ei)) { + err = ext4_inode_blocks_set(handle, raw_inode, ei); + if (err) { spin_unlock(&ei->i_raw_lock); goto out_brelse; }
When ext4_do_update_inode() gets error from ext4_inode_blocks_set(), error number should be returned. Signed-off-by: Li Xi <lixi@ddn.com> --- fs/ext4/inode.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)