diff mbox

[11,of,15] pkg-generic: introduce helper function to check for a deprecated variable

Message ID 61d1ac081581b741bf4e.1411846368@localhost
State Accepted
Headers show

Commit Message

Thomas De Schampheleire Sept. 27, 2014, 7:32 p.m. UTC 
This patch introduces a helper check-deprecated-variable, that throws an
error when a package defines a deprecated variable. This helps in detecting
transition errors when changing the buildroot infrastructures, and also
helps users that have created packages not part of mainline buildroot.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

---
v2: no changes

 package/pkg-generic.mk |  15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

Comments

Thomas Petazzoni Oct. 4, 2014, 5:13 p.m. UTC | #1 
Dear Thomas De Schampheleire,

On Sat, 27 Sep 2014 21:32:48 +0200, Thomas De Schampheleire wrote:

>  ################################################################################
> +# check-deprecated-variable -- throw an error on deprecated variables
> +#
> +# argument 1 is the deprecated variable
> +# argument 2 is the new variable to use
> +#
> +# example:
> +#   $(eval $(call check-deprecated-variable,FOO_MAKE_OPT,FOO_MAKE_OPTS))
> +################################################################################
> +define check-deprecated-variable
> +ifneq ($$(origin $(1)),undefined)
> +$$(error Package error: use $(2) instead of $(1). Please fix your .mk file)
> +endif
> +endef

This helper should rather go in pkg-utils.mk. See my comment on PATCH
12 for explanations.

Thomas
diff mbox

Patch

diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -264,6 +264,21 @@ 
 endef
 
 ################################################################################
+# check-deprecated-variable -- throw an error on deprecated variables
+#
+# argument 1 is the deprecated variable
+# argument 2 is the new variable to use
+#
+# example:
+#   $(eval $(call check-deprecated-variable,FOO_MAKE_OPT,FOO_MAKE_OPTS))
+################################################################################
+define check-deprecated-variable
+ifneq ($$(origin $(1)),undefined)
+$$(error Package error: use $(2) instead of $(1). Please fix your .mk file)
+endif
+endef
+
+################################################################################
 # inner-generic-package -- generates the make targets needed to build a
 # generic package
 #