| Message ID | 1411662520-22795-3-git-send-email-geert+renesas@glider.be |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 25 September 2014 18:28, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > PM domain power on/off-latencies are properties of the hardware. > In legacy code, they're specified from platform code. > On DT platforms, their values should come from DT. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Acked-by: Kevin Hilman <khilman@linaro.org> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > v3: > - No changes > v2: > - Add Acked-by > > Documentation/devicetree/bindings/power/power_domain.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/power_domain.txt b/Documentation/devicetree/bindings/power/power_domain.txt > index 98c16672ab5f49e0..7bc421d84367d636 100644 > --- a/Documentation/devicetree/bindings/power/power_domain.txt > +++ b/Documentation/devicetree/bindings/power/power_domain.txt > @@ -19,12 +19,18 @@ Required properties: > providing multiple PM domains (e.g. power controllers), but can be any value > as specified by device tree binding documentation of particular provider. > > +Optional properties: > + - power-on-latency: Power-on latency of the PM domain, in ns, > + - power-off-latency: Power-off latency of the PM domain, in ns. > + > Example: > > power: power-controller@12340000 { > compatible = "foo,power-controller"; > reg = <0x12340000 0x1000>; > #power-domain-cells = <1>; > + power-on-latency = <250000>; > + power-off-latency = <250000>; > }; > > The node above defines a power controller that is a PM domain provider and > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> On 25 September 2014 18:28, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > +Optional properties: > > + - power-on-latency: Power-on latency of the PM domain, in ns, > > + - power-off-latency: Power-off latency of the PM domain, in ns. > > + > > Example: > > > > power: power-controller@12340000 { > > compatible = "foo,power-controller"; > > reg = <0x12340000 0x1000>; > > #power-domain-cells = <1>; > > + power-on-latency = <250000>; > > + power-off-latency = <250000>; This assumes every power domain within a power controller has the same latencies? That isn't always true. This should be an array of values corresponding to the number of power domains if #power-domain-cells is 1, or just one value if the cell count is 0.
Hi Stephen, On Fri, Sep 26, 2014 at 5:28 PM, Stephen Boyd <sboyd@codeaurora.org> wrote: >> On 25 September 2014 18:28, Geert Uytterhoeven <geert+renesas@glider.be> wrote: >> > +Optional properties: >> > + - power-on-latency: Power-on latency of the PM domain, in ns, >> > + - power-off-latency: Power-off latency of the PM domain, in ns. >> > + >> > Example: >> > >> > power: power-controller@12340000 { >> > compatible = "foo,power-controller"; >> > reg = <0x12340000 0x1000>; >> > #power-domain-cells = <1>; >> > + power-on-latency = <250000>; >> > + power-off-latency = <250000>; > > This assumes every power domain within a power controller has the > same latencies? That isn't always true. This should be an array > of values corresponding to the number of power domains if > #power-domain-cells is 1, or just one value if the cell count is > 0. Thanks, you're right. Will update. However, I'd still like to allow just one value in the #power-domain-cells = <1> case if the latencies are the same. Is that OK for you? Thanks again. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/power/power_domain.txt b/Documentation/devicetree/bindings/power/power_domain.txt index 98c16672ab5f49e0..7bc421d84367d636 100644 --- a/Documentation/devicetree/bindings/power/power_domain.txt +++ b/Documentation/devicetree/bindings/power/power_domain.txt @@ -19,12 +19,18 @@ Required properties: providing multiple PM domains (e.g. power controllers), but can be any value as specified by device tree binding documentation of particular provider. +Optional properties: + - power-on-latency: Power-on latency of the PM domain, in ns, + - power-off-latency: Power-off latency of the PM domain, in ns. + Example: power: power-controller@12340000 { compatible = "foo,power-controller"; reg = <0x12340000 0x1000>; #power-domain-cells = <1>; + power-on-latency = <250000>; + power-off-latency = <250000>; }; The node above defines a power controller that is a PM domain provider and