| Message ID | 337231c0fc8b16b4f37e1e3b85cb0246f357a64d.1411513109.git.joshc@codeaurora.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Tuesday 23 September 2014 18:04:37 Josh Cartwright wrote:
> +- clocks : shall contain the input clock phandle
Just nitpicking, but this is not just a phandle, it's a clock
descriptor, which is a phandle followed by a set of arguments,
which may be empty, depending the on the clock controller
implementation.
I would just call it 'the input clock', rather than 'input clock
phandle'.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Sep 24, 2014 at 11:44:44AM +0100, Arnd Bergmann wrote: > On Tuesday 23 September 2014 18:04:37 Josh Cartwright wrote: > > +- clocks : shall contain the input clock phandle > > Just nitpicking, but this is not just a phandle, it's a clock > descriptor, which is a phandle followed by a set of arguments, > which may be empty, depending the on the clock controller > implementation. We're _extremely_ inconsistent with terminology, so it's not confusing people don't know what to put here. Elsewhere people say "phandle + clock specifier" (which is correct), "clock reference" (which is ok, but sounds like a phandle), etc. From what I recall some documentation says some *-specifier properties include the phandle too. It would be really nice if we had one consistent way of refering to phandle+args style properties. > > I would just call it 'the input clock', rather than 'input clock > phandle'. That's fine by me, given clocks is a well-understood standard property. Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt new file mode 100644 index 0000000..6a1d758 --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt @@ -0,0 +1,22 @@ +Qualcomm Krait Processor Sub-system (KPSS) Watchdog +--------------------------------------------------- + +Required properties : +- compatible : shall contain only one of the following: + + "qcom,kpss-wdt-msm8960" + "qcom,kpss-wdt-apq8064" + "qcom,kpss-wdt-ipq8064" + +- reg : shall contain base register location and length +- clocks : shall contain the input clock phandle +- timeout-sec : shall contain the default watchdog timeout in seconds, + if unset, the default timeout is 30 seconds + +Example: + watchdog@208a038 { + compatible = "qcom,kpss-wdt-ipq8064"; + reg = <0x0208a038 0x40>; + clocks = <&sleep_clk>; + timeout-sec = <10>; + };
The Qualcomm Krait Processor Sub-system (KPSS) contains one or more instances of the WDT. Provide documentation on how to describe these in the device tree. Signed-off-by: Josh Cartwright <joshc@codeaurora.org> --- .../devicetree/bindings/watchdog/qcom-wdt.txt | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt