diff mbox

[net-next] sparc: bpf_jit: add support for BPF_LD(X) | BPF_LEN instructions

Message ID 1411508171-10740-1-git-send-email-ast@plumgrid.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Alexei Starovoitov Sept. 23, 2014, 9:36 p.m. UTC
BPF_LD | BPF_W | BPF_LEN instruction is occasionally used by tcpdump
and present in 11 tests in lib/test_bpf.c
Teach sparc JIT compiler to emit it.

Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
---

coupled with pending net fix test_bpf still comes out clean on sparc64.
compile tested only on sparc32

Though both patches touch the same file, there should be no conflicts
between net and net-next.

 arch/sparc/net/bpf_jit_comp.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

David Miller Sept. 26, 2014, 8:52 p.m. UTC | #1
From: Alexei Starovoitov <ast@plumgrid.com>
Date: Tue, 23 Sep 2014 14:36:11 -0700

> BPF_LD | BPF_W | BPF_LEN instruction is occasionally used by tcpdump
> and present in 11 tests in lib/test_bpf.c
> Teach sparc JIT compiler to emit it.
> 
> Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>

Applied, thanks Alexei.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/sparc/net/bpf_jit_comp.c b/arch/sparc/net/bpf_jit_comp.c
index 7c06f18150ab..86bad49d6604 100644
--- a/arch/sparc/net/bpf_jit_comp.c
+++ b/arch/sparc/net/bpf_jit_comp.c
@@ -624,7 +624,12 @@  void bpf_jit_compile(struct bpf_prog *fp)
 					emit_and(r_A, r_TMP, r_A);
 				}
 				break;
-
+			case BPF_LD | BPF_W | BPF_LEN:
+				emit_skb_load32(len, r_A);
+				break;
+			case BPF_LDX | BPF_W | BPF_LEN:
+				emit_skb_load32(len, r_X);
+				break;
 			case BPF_LD | BPF_IMM:
 				emit_loadimm(K, r_A);
 				break;