Message ID | 1411450671-2367-1-git-send-email-chuansheng.liu@intel.com |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
On Tue, Sep 23, 2014 at 01:37:51PM +0800, Chuansheng Liu wrote: > Be similar with commit (ata: Disabling the async PM for JMicron chip 363/361), Please use 12_DIGIT_SHA1_PREFIX ("SUBJ") format when referring to commits. > Barto found the similar issue for JMicron chip 368, that 363/368 has no > parent-children relationship, but they have the power dependency. > > So here we can exclude the JMicron chips out of pm_async method directly, > to avoid further similar issues. > > Details in: > https://bugzilla.kernel.org/show_bug.cgi?id=84861 > > Reported-and-tested-by: Barto <mister.freeman@laposte.net> > Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> > --- > drivers/ata/ahci.c | 6 +++--- > drivers/ata/pata_jmicron.c | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > index a0cc0ed..c096d49 100644 > --- a/drivers/ata/ahci.c > +++ b/drivers/ata/ahci.c > @@ -1345,10 +1345,10 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > * follow the sequence one by one, otherwise one of them can not be > * powered on successfully, so here we disable the async suspend > * method for these chips. > + * Jmicron chip 368 has been found has the similar issue, here we can > + * exclude the Jmicron family directly to avoid other similar issues. Let's update the comment as a whole instead of appending to it. Thanks.
> -----Original Message----- > From: Tejun Heo [mailto:htejun@gmail.com] On Behalf Of Tejun Heo > Sent: Tuesday, September 23, 2014 10:01 PM > To: Liu, Chuansheng > Cc: rjw@rjwysocki.net; linux-ide@vger.kernel.org; > linux-kernel@vger.kernel.org; mister.freeman@laposte.net; Zhang, Rui > Subject: Re: [PATCH] ata: Disabling the async PM for JMicron chips > > On Tue, Sep 23, 2014 at 01:37:51PM +0800, Chuansheng Liu wrote: > > Be similar with commit (ata: Disabling the async PM for JMicron chip > 363/361), > > Please use 12_DIGIT_SHA1_PREFIX ("SUBJ") format when referring to > commits. > > > @@ -1345,10 +1345,10 @@ static int ahci_init_one(struct pci_dev *pdev, > const struct pci_device_id *ent) > > * follow the sequence one by one, otherwise one of them can not be > > * powered on successfully, so here we disable the async suspend > > * method for these chips. > > + * Jmicron chip 368 has been found has the similar issue, here we can > > + * exclude the Jmicron family directly to avoid other similar issues. > > Let's update the comment as a whole instead of appending to it. > Thanks your comments, Tejun, will send one new patch to review. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index a0cc0ed..c096d49 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -1345,10 +1345,10 @@ static int ahci_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) * follow the sequence one by one, otherwise one of them can not be * powered on successfully, so here we disable the async suspend * method for these chips. + * Jmicron chip 368 has been found has the similar issue, here we can + * exclude the Jmicron family directly to avoid other similar issues. */ - if (pdev->vendor == PCI_VENDOR_ID_JMICRON && - (pdev->device == PCI_DEVICE_ID_JMICRON_JMB363 || - pdev->device == PCI_DEVICE_ID_JMICRON_JMB361)) + if (pdev->vendor == PCI_VENDOR_ID_JMICRON) device_disable_async_suspend(&pdev->dev); /* acquire resources */ diff --git a/drivers/ata/pata_jmicron.c b/drivers/ata/pata_jmicron.c index 47e418b..48c993b 100644 --- a/drivers/ata/pata_jmicron.c +++ b/drivers/ata/pata_jmicron.c @@ -149,10 +149,10 @@ static int jmicron_init_one (struct pci_dev *pdev, const struct pci_device_id *i * follow the sequence one by one, otherwise one of them can not be * powered on successfully, so here we disable the async suspend * method for these chips. + * Jmicron chip 368 has been found has the similar issue, here we can + * exclude the Jmicron family directly to avoid other similar issues. */ - if (pdev->vendor == PCI_VENDOR_ID_JMICRON && - (pdev->device == PCI_DEVICE_ID_JMICRON_JMB363 || - pdev->device == PCI_DEVICE_ID_JMICRON_JMB361)) + if (pdev->vendor == PCI_VENDOR_ID_JMICRON) device_disable_async_suspend(&pdev->dev); return ata_pci_bmdma_init_one(pdev, ppi, &jmicron_sht, NULL, 0);
Be similar with commit (ata: Disabling the async PM for JMicron chip 363/361), Barto found the similar issue for JMicron chip 368, that 363/368 has no parent-children relationship, but they have the power dependency. So here we can exclude the JMicron chips out of pm_async method directly, to avoid further similar issues. Details in: https://bugzilla.kernel.org/show_bug.cgi?id=84861 Reported-and-tested-by: Barto <mister.freeman@laposte.net> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> --- drivers/ata/ahci.c | 6 +++--- drivers/ata/pata_jmicron.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)