From patchwork Tue Nov 24 10:05:04 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: net: initialize vnet_hdr in net_tap_init() Date: Tue, 24 Nov 2009 00:05:04 -0000 From: Mark McLoughlin X-Patchwork-Id: 39197 Message-Id: <1259057104.8935.18.camel@blaa> To: Pierre Riteau Cc: qemu-devel@nongnu.org Hi Pierre, On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote: > vnet_hdr is initialized at 1 by default. We need to reset it to 0 if > the kernel doesn't support IFF_VNET_HDR. Thanks for the patch, but I'd prefer us to make sure we catch all cases. Does this work for you? Thanks, Mark. From: Mark McLoughlin Subject: [PATCH] net: initialize vnet_hdr in net_tap_init() Don't assume that all tap_open() implementations will set it to zero if VNET_HDR support isn't found. Fixes tap networking on host kernels lacking IFF_VNET_HDR support. Reported-by: Pierre Riteau Signed-off-by: Mark McLoughlin --- net/tap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/tap.c b/net/tap.c index d34feec..7fb9e16 100644 --- a/net/tap.c +++ b/net/tap.c @@ -378,7 +378,7 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr) int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlan) { TAPState *s; - int fd, vnet_hdr; + int fd, vnet_hdr = 0; if (qemu_opt_get(opts, "fd")) { if (qemu_opt_get(opts, "ifname") ||