| Message ID | 1411305204-11731-3-git-send-email-marex@denx.de |
|---|---|
| State | Superseded |
| Delegated to: | Marek Vasut |
| Headers | show |
On Sun, 21 Sep 2014, Marek Vasut wrote: > Enable support for the DWC2 USB controller. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Chin Liang See <clsee@altera.com> > Cc: Dinh Nguyen <dinguyen@altera.com> > Cc: Albert Aribaud <albert.u.boot@aribaud.net> > Cc: Tom Rini <trini@ti.com> > Cc: Wolfgang Denk <wd@denx.de> > Cc: Pavel Machek <pavel@denx.de> > --- > include/configs/socfpga_cyclone5_common.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/configs/socfpga_cyclone5_common.h b/include/configs/socfpga_cyclone5_common.h > index 49504dc..3f8f91f 100644 > --- a/include/configs/socfpga_cyclone5_common.h > +++ b/include/configs/socfpga_cyclone5_common.h > @@ -157,6 +157,14 @@ > #define CONFIG_BAUDRATE 115200 > > /* > + * USB > + */ > +#ifdef CONFIG_CMD_USB > +#define CONFIG_USB_DWC2 > +#define CONFIG_USB_STORAGE Don't you also need: #define CONFIG_USB_DWC2_REG_ADDR 0xffb40000 for the base address for the USB1 on SOCFPGA? BR, Dinh
On Tuesday, September 23, 2014 at 09:55:59 PM, Dinh Nguyen wrote: > On Sun, 21 Sep 2014, Marek Vasut wrote: > > Enable support for the DWC2 USB controller. > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Chin Liang See <clsee@altera.com> > > Cc: Dinh Nguyen <dinguyen@altera.com> > > Cc: Albert Aribaud <albert.u.boot@aribaud.net> > > Cc: Tom Rini <trini@ti.com> > > Cc: Wolfgang Denk <wd@denx.de> > > Cc: Pavel Machek <pavel@denx.de> > > --- > > > > include/configs/socfpga_cyclone5_common.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/include/configs/socfpga_cyclone5_common.h > > b/include/configs/socfpga_cyclone5_common.h index 49504dc..3f8f91f > > 100644 > > --- a/include/configs/socfpga_cyclone5_common.h > > +++ b/include/configs/socfpga_cyclone5_common.h > > @@ -157,6 +157,14 @@ > > > > #define CONFIG_BAUDRATE 115200 > > > > /* > > > > + * USB > > + */ > > +#ifdef CONFIG_CMD_USB > > +#define CONFIG_USB_DWC2 > > +#define CONFIG_USB_STORAGE > > Don't you also need: > > #define CONFIG_USB_DWC2_REG_ADDR 0xffb40000 > > for the base address for the USB1 on SOCFPGA? Yes, you need to do that, but there are actually two USB controllers in the SoCFPGA CV, so this is up to the user to pick one and define it in his separate board header file (socfpga_cyclone5.h or similar). So far, the DWC2 driver supports only single controller (this needs to be fixed). Best regards, Marek Vasut
On Tue, Sep 23, 2014 at 2:55 PM, Dinh Nguyen <dinguyen@opensource.altera.com> wrote: > On Sun, 21 Sep 2014, Marek Vasut wrote: > >> Enable support for the DWC2 USB controller. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> Cc: Chin Liang See <clsee@altera.com> >> Cc: Dinh Nguyen <dinguyen@altera.com> >> Cc: Albert Aribaud <albert.u.boot@aribaud.net> >> Cc: Tom Rini <trini@ti.com> >> Cc: Wolfgang Denk <wd@denx.de> >> Cc: Pavel Machek <pavel@denx.de> >> --- >> include/configs/socfpga_cyclone5_common.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/include/configs/socfpga_cyclone5_common.h b/include/configs/socfpga_cyclone5_common.h >> index 49504dc..3f8f91f 100644 >> --- a/include/configs/socfpga_cyclone5_common.h >> +++ b/include/configs/socfpga_cyclone5_common.h >> @@ -157,6 +157,14 @@ >> #define CONFIG_BAUDRATE 115200 >> >> /* >> + * USB >> + */ >> +#ifdef CONFIG_CMD_USB >> +#define CONFIG_USB_DWC2 >> +#define CONFIG_USB_STORAGE > > Don't you also need: > > #define CONFIG_USB_DWC2_REG_ADDR 0xffb40000 > > for the base address for the USB1 on SOCFPGA? > Now that I saw patch 50/51 "arm: socfpga: Split SoCFPGA configuration", I think these defines should go into socfpga_cyclone5.h Dinh
On Wednesday, September 24, 2014 at 12:21:04 AM, Dinh Nguyen wrote: > On Tue, Sep 23, 2014 at 2:55 PM, Dinh Nguyen > > <dinguyen@opensource.altera.com> wrote: > > On Sun, 21 Sep 2014, Marek Vasut wrote: > >> Enable support for the DWC2 USB controller. > >> > >> Signed-off-by: Marek Vasut <marex@denx.de> > >> Cc: Chin Liang See <clsee@altera.com> > >> Cc: Dinh Nguyen <dinguyen@altera.com> > >> Cc: Albert Aribaud <albert.u.boot@aribaud.net> > >> Cc: Tom Rini <trini@ti.com> > >> Cc: Wolfgang Denk <wd@denx.de> > >> Cc: Pavel Machek <pavel@denx.de> > >> --- > >> > >> include/configs/socfpga_cyclone5_common.h | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > >> diff --git a/include/configs/socfpga_cyclone5_common.h > >> b/include/configs/socfpga_cyclone5_common.h index 49504dc..3f8f91f > >> 100644 > >> --- a/include/configs/socfpga_cyclone5_common.h > >> +++ b/include/configs/socfpga_cyclone5_common.h > >> @@ -157,6 +157,14 @@ > >> > >> #define CONFIG_BAUDRATE 115200 > >> > >> /* > >> > >> + * USB > >> + */ > >> +#ifdef CONFIG_CMD_USB > >> +#define CONFIG_USB_DWC2 > >> +#define CONFIG_USB_STORAGE > > > > Don't you also need: > > > > #define CONFIG_USB_DWC2_REG_ADDR 0xffb40000 > > > > for the base address for the USB1 on SOCFPGA? > > Now that I saw patch 50/51 "arm: socfpga: Split SoCFPGA configuration", > I think these defines should go into socfpga_cyclone5.h Yeah, the board specific goes into socfpga_cyclone5.h , since that's de-facto support for the SoCDK board. The "generic" part goes into socfpga_cyclone5_common.h . Best regards, Marek Vasut
diff --git a/include/configs/socfpga_cyclone5_common.h b/include/configs/socfpga_cyclone5_common.h index 49504dc..3f8f91f 100644 --- a/include/configs/socfpga_cyclone5_common.h +++ b/include/configs/socfpga_cyclone5_common.h @@ -157,6 +157,14 @@ #define CONFIG_BAUDRATE 115200 /* + * USB + */ +#ifdef CONFIG_CMD_USB +#define CONFIG_USB_DWC2 +#define CONFIG_USB_STORAGE +#endif + +/* * U-Boot environment */ #define CONFIG_SYS_CONSOLE_IS_IN_ENV
Enable support for the DWC2 USB controller. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Chin Liang See <clsee@altera.com> Cc: Dinh Nguyen <dinguyen@altera.com> Cc: Albert Aribaud <albert.u.boot@aribaud.net> Cc: Tom Rini <trini@ti.com> Cc: Wolfgang Denk <wd@denx.de> Cc: Pavel Machek <pavel@denx.de> --- include/configs/socfpga_cyclone5_common.h | 8 ++++++++ 1 file changed, 8 insertions(+)