| Message ID | 20140917191131.20529.91136.stgit@nitbit.x32 |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 09/17/2014 12:11 PM, John Fastabend wrote: > This fixes a missed free_percpu in the unwind code path and when > keys are destroyed. > > Signed-off-by: John Fastabend <john.r.fastabend@intel.com> > --- > net/sched/cls_u32.c | 6 ++++++ > 1 file changed, 6 insertions(+) > This patch still misses free'ing pcpu_success in an error path so I'll address it when I send a v2 to address comments on the second patch
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 730edb2..e76d50b 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@ -363,6 +363,9 @@ static int u32_destroy_key(struct tcf_proto *tp, struct tc_u_knode *n) #ifdef CONFIG_CLS_U32_PERF free_percpu(n->pf); #endif +#ifdef CONFIG_CLS_U32_MARK + free_percpu(n->pcpu_success); +#endif kfree(n); return 0; } @@ -723,6 +726,9 @@ static int u32_change(struct net *net, struct sk_buff *in_skb, #ifdef CONFIG_CLS_U32_PERF free_percpu(n->pf); #endif +#ifdef CONFIG_CLS_U32_MARK + free_percpu(n->pcpu_success); +#endif kfree(n); return err; }
This fixes a missed free_percpu in the unwind code path and when keys are destroyed. Signed-off-by: John Fastabend <john.r.fastabend@intel.com> --- net/sched/cls_u32.c | 6 ++++++ 1 file changed, 6 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html