From patchwork Mon Nov 23 13:00:43 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: seabios: missing DMI type 4 entry if -cpu parameter is used
Date: Mon, 23 Nov 2009 03:00:43 -0000
From: Gleb Natapov <gleb@redhat.com>
X-Patchwork-Id: 39049
Message-Id: <20091123130043.GN2999@redhat.com>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: Kevin O'Connor <kevin@koconnor.net>, qemu-devel@nongnu.org

On Sun, Nov 22, 2009 at 06:05:02PM +0100, Sebastian Herbszt wrote:
> v0.11.0-rc0-1677:
> use -cpu pentium and check SMBIOS tables. DMI type 4 entry is missing.
> Works with Bochs bios.
> 
See two problems here. First one in seabios (patch attached). And the
second one in QEMU. Why pentium cpu type lacks apic? Specifying 
-cpu pentium,+apic works with current seabios without the patch.

Signed-off-by: Gleb Natapov <gleb@redhat.com>

---
Gleb.

diff --git a/src/smp.c b/src/smp.c
index 7100476..00cf64b 100644
--- a/src/smp.c
+++ b/src/smp.c
@@ -75,7 +75,9 @@ smp_probe(void)
     cpuid(1, &eax, &ebx, &ecx, &cpuid_features);
     if (! (cpuid_features & CPUID_APIC)) {
         // No apic - only the main cpu is present.
+        dprintf(1, "No apic - only the main cpu is present.\n");
         CountCPUs= 1;
+        MaxCountCPUs = 1;
         return;
     }