From patchwork Mon Nov 23 13:00:43 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gleb Natapov X-Patchwork-Id: 39049 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CC5791007D1 for ; Tue, 24 Nov 2009 00:02:18 +1100 (EST) Received: from localhost ([127.0.0.1]:59562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NCYYZ-00051V-Jz for incoming@patchwork.ozlabs.org; Mon, 23 Nov 2009 08:02:15 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NCYXI-0004ic-Sv for qemu-devel@nongnu.org; Mon, 23 Nov 2009 08:00:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NCYXE-0004gx-PP for qemu-devel@nongnu.org; Mon, 23 Nov 2009 08:00:56 -0500 Received: from [199.232.76.173] (port=45485 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NCYXE-0004gr-Ic for qemu-devel@nongnu.org; Mon, 23 Nov 2009 08:00:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35512) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NCYXE-0003aV-1J for qemu-devel@nongnu.org; Mon, 23 Nov 2009 08:00:52 -0500 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAND0lQf000401 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 23 Nov 2009 08:00:47 -0500 Received: from dhcp-1-237.tlv.redhat.com (dhcp-1-237.tlv.redhat.com [10.35.1.237]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAND0iiB014807; Mon, 23 Nov 2009 08:00:44 -0500 Received: by dhcp-1-237.tlv.redhat.com (Postfix, from userid 13519) id ED3CC18D46A; Mon, 23 Nov 2009 15:00:43 +0200 (IST) Date: Mon, 23 Nov 2009 15:00:43 +0200 From: Gleb Natapov To: Sebastian Herbszt Subject: Re: [Qemu-devel] seabios: missing DMI type 4 entry if -cpu parameter is used Message-ID: <20091123130043.GN2999@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.67 on 10.5.11.16 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Kevin O'Connor , qemu-devel@nongnu.org X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Sun, Nov 22, 2009 at 06:05:02PM +0100, Sebastian Herbszt wrote: > v0.11.0-rc0-1677: > use -cpu pentium and check SMBIOS tables. DMI type 4 entry is missing. > Works with Bochs bios. > See two problems here. First one in seabios (patch attached). And the second one in QEMU. Why pentium cpu type lacks apic? Specifying -cpu pentium,+apic works with current seabios without the patch. Signed-off-by: Gleb Natapov --- Gleb. diff --git a/src/smp.c b/src/smp.c index 7100476..00cf64b 100644 --- a/src/smp.c +++ b/src/smp.c @@ -75,7 +75,9 @@ smp_probe(void) cpuid(1, &eax, &ebx, &ecx, &cpuid_features); if (! (cpuid_features & CPUID_APIC)) { // No apic - only the main cpu is present. + dprintf(1, "No apic - only the main cpu is present.\n"); CountCPUs= 1; + MaxCountCPUs = 1; return; }