| Message ID | 1410964242-3341-3-git-send-email-owen.smith@citrix.com |
|---|---|
| State | New |
| Headers | show |
On Wed, 17 Sep 2014, Owen smith wrote: > Without activating the mouse event handler, mouse events are not > delivered to the new handler. Input events are only delivered to > the first matching handler in the input chain. Activating a handler > moves the handler to the start of the chain. > > Note: qemu_add_kbd_event_handler adds and activates the keyboard > handler, where qemu_add_mouse_event_handler does not activate the > mouse handler. how strange > Signed-off-by: Owen smith <owen.smith@citrix.com> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > --- > hw/display/xenfb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c > index 9dcf9b6..69471e9 100644 > --- a/hw/display/xenfb.c > +++ b/hw/display/xenfb.c > @@ -383,6 +383,7 @@ static void input_connected(struct XenDevice *xendev) > in->qmouse = qemu_add_mouse_event_handler(xenfb_mouse_event, in, > in->abs_pointer_wanted, > "Xen PVFB Mouse"); > + qemu_activate_mouse_event_handler(in->qmouse); > > if (in->qkbd) { > qemu_remove_kbd_event_handler(in->qkbd); > -- > 2.1.0 >
diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index 9dcf9b6..69471e9 100644 --- a/hw/display/xenfb.c +++ b/hw/display/xenfb.c @@ -383,6 +383,7 @@ static void input_connected(struct XenDevice *xendev) in->qmouse = qemu_add_mouse_event_handler(xenfb_mouse_event, in, in->abs_pointer_wanted, "Xen PVFB Mouse"); + qemu_activate_mouse_event_handler(in->qmouse); if (in->qkbd) { qemu_remove_kbd_event_handler(in->qkbd);
Without activating the mouse event handler, mouse events are not delivered to the new handler. Input events are only delivered to the first matching handler in the input chain. Activating a handler moves the handler to the start of the chain. Note: qemu_add_kbd_event_handler adds and activates the keyboard handler, where qemu_add_mouse_event_handler does not activate the mouse handler. Signed-off-by: Owen smith <owen.smith@citrix.com> --- hw/display/xenfb.c | 1 + 1 file changed, 1 insertion(+)