Patchwork isa: serial+parallel: fixup index property.

login
register
mail settings
Submitter Gerd Hoffmann
Date Nov. 23, 2009, 9:07 a.m.
Message ID <1258967278-4021-1-git-send-email-kraxel@redhat.com>
Download mbox | patch
Permalink /patch/39040/
State New
Headers show

Comments

Gerd Hoffmann - Nov. 23, 2009, 9:07 a.m.
The index property for both isa-serial and isa-parallel is declared as
hex number whereas it should be int.  Fix it.
---
 hw/parallel.c |    2 +-
 hw/serial.c   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Markus Armbruster - Nov. 23, 2009, 10:01 a.m.
Gerd Hoffmann <kraxel@redhat.com> writes:

> The index property for both isa-serial and isa-parallel is declared as
> hex number whereas it should be int.  Fix it.

Yes, that's much better.

Patch

diff --git a/hw/parallel.c b/hw/parallel.c
index 5ae8348..12693d4 100644
--- a/hw/parallel.c
+++ b/hw/parallel.c
@@ -587,7 +587,7 @@  static ISADeviceInfo parallel_isa_info = {
     .qdev.size  = sizeof(ISAParallelState),
     .init       = parallel_isa_initfn,
     .qdev.props = (Property[]) {
-        DEFINE_PROP_HEX32("index",  ISAParallelState, index,   -1),
+        DEFINE_PROP_UINT32("index", ISAParallelState, index,   -1),
         DEFINE_PROP_HEX32("iobase", ISAParallelState, iobase,  -1),
         DEFINE_PROP_UINT32("irq",   ISAParallelState, isairq,  7),
         DEFINE_PROP_CHR("chardev",  ISAParallelState, state.chr),
diff --git a/hw/serial.c b/hw/serial.c
index 0063260..e7538ac 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -900,7 +900,7 @@  static ISADeviceInfo serial_isa_info = {
     .qdev.size  = sizeof(ISASerialState),
     .init       = serial_isa_initfn,
     .qdev.props = (Property[]) {
-        DEFINE_PROP_HEX32("index",  ISASerialState, index,   -1),
+        DEFINE_PROP_UINT32("index", ISASerialState, index,   -1),
         DEFINE_PROP_HEX32("iobase", ISASerialState, iobase,  -1),
         DEFINE_PROP_UINT32("irq",   ISASerialState, isairq,  -1),
         DEFINE_PROP_CHR("chardev",  ISASerialState, state.chr),