Message ID | 1410959085-7351-2-git-send-email-nhorman@tuxdriver.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Neil Horman <nhorman@tuxdriver.com> Date: Wed, 17 Sep 2014 09:04:45 -0400 > Recently aded the use of skb_frag_dma_map to 3c59x, but didn't realize it > automatically included the frag_offset internally, as well as provided an option > to specify an extra offset in the parameter list. We need to specify an offset > of 0 in the parameter list to avoid skb corruption that results in lost > connections. > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com> > CC: Linux Kernel list <linux-kernel@vger.kernel.org> > CC: "David S. Miller" <davem@davemloft.net> > CC: Meelis Roos <mroos@linux.ee> > Tested-by: Meelis Roos <mroos@linux.ee> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c index 5621dab..0f59d68 100644 --- a/drivers/net/ethernet/3com/3c59x.c +++ b/drivers/net/ethernet/3com/3c59x.c @@ -2186,7 +2186,7 @@ boomerang_start_xmit(struct sk_buff *skb, struct net_device *dev) skb_frag_t *frag = &skb_shinfo(skb)->frags[i]; dma_addr = skb_frag_dma_map(&VORTEX_PCI(vp)->dev, frag, - frag->page_offset, + 0, frag->size, DMA_TO_DEVICE); if (dma_mapping_error(&VORTEX_PCI(vp)->dev, dma_addr)) {