[v2,06/19] Define IN_MODULE for translation units that define NOT_IN_libc
diff mbox

Message ID 20140917122939.GT6586@spoyarek.pnq.redhat.com
State New
Headers show

Commit Message

Siddhesh Poyarekar Sept. 17, 2014, 12:29 p.m. UTC
Hi,

I have now rebased this patch against the current master.  interp.c
does not need the CPPFLAGS anymore, so sotruss-lib is the only code to
be built as extramodules to eventually replace the NOT_IN_libc macro.

Build tested on x86_64 to ensure that the generated code is unchanged.

Siddhesh

    	* elf/Makefile (libof-sotruss-lib): Set as extramodules.

Comments

Siddhesh Poyarekar Sept. 24, 2014, 9:07 a.m. UTC | #1
Ping!

On Wed, Sep 17, 2014 at 05:59:40PM +0530, Siddhesh Poyarekar wrote:
> Hi,
> 
> I have now rebased this patch against the current master.  interp.c
> does not need the CPPFLAGS anymore, so sotruss-lib is the only code to
> be built as extramodules to eventually replace the NOT_IN_libc macro.
> 
> Build tested on x86_64 to ensure that the generated code is unchanged.
> 
> Siddhesh
> 
>     	* elf/Makefile (libof-sotruss-lib): Set as extramodules.
> 
> diff --git a/elf/Makefile b/elf/Makefile
> index 677635b..7a5a9aa 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -96,6 +96,7 @@ extra-objs += sotruss-lib.os sotruss-lib.so
>  install-others += $(inst_auditdir)/sotruss-lib.so
>  install-bin-script += sotruss
>  generated += sotruss
> +libof-sotruss-lib = extramodules
>  CPPFLAGS-sotruss-lib = -DNOT_IN_libc
>  $(objpfx)sotruss-lib.so: $(objpfx)sotruss-lib.os
>  	$(build-module-asneeded)
Siddhesh Poyarekar Oct. 1, 2014, 8:22 a.m. UTC | #2
Rebased against current upstream and patch is unchanged.

Ping!

Siddhesh

On Wed, Sep 24, 2014 at 02:37:31PM +0530, Siddhesh Poyarekar wrote:
> Ping!
> 
> On Wed, Sep 17, 2014 at 05:59:40PM +0530, Siddhesh Poyarekar wrote:
> > Hi,
> > 
> > I have now rebased this patch against the current master.  interp.c
> > does not need the CPPFLAGS anymore, so sotruss-lib is the only code to
> > be built as extramodules to eventually replace the NOT_IN_libc macro.
> > 
> > Build tested on x86_64 to ensure that the generated code is unchanged.
> > 
> > Siddhesh
> > 
> >     	* elf/Makefile (libof-sotruss-lib): Set as extramodules.
> > 
> > diff --git a/elf/Makefile b/elf/Makefile
> > index 677635b..7a5a9aa 100644
> > --- a/elf/Makefile
> > +++ b/elf/Makefile
> > @@ -96,6 +96,7 @@ extra-objs += sotruss-lib.os sotruss-lib.so
> >  install-others += $(inst_auditdir)/sotruss-lib.so
> >  install-bin-script += sotruss
> >  generated += sotruss
> > +libof-sotruss-lib = extramodules
> >  CPPFLAGS-sotruss-lib = -DNOT_IN_libc
> >  $(objpfx)sotruss-lib.so: $(objpfx)sotruss-lib.os
> >  	$(build-module-asneeded)
> 
>
Siddhesh Poyarekar Oct. 14, 2014, 4:22 p.m. UTC | #3
Ping!

On Wed, Oct 01, 2014 at 01:52:54PM +0530, Siddhesh Poyarekar wrote:
> Rebased against current upstream and patch is unchanged.
> 
> Ping!
> 
> Siddhesh
> 
> On Wed, Sep 24, 2014 at 02:37:31PM +0530, Siddhesh Poyarekar wrote:
> > Ping!
> > 
> > On Wed, Sep 17, 2014 at 05:59:40PM +0530, Siddhesh Poyarekar wrote:
> > > Hi,
> > > 
> > > I have now rebased this patch against the current master.  interp.c
> > > does not need the CPPFLAGS anymore, so sotruss-lib is the only code to
> > > be built as extramodules to eventually replace the NOT_IN_libc macro.
> > > 
> > > Build tested on x86_64 to ensure that the generated code is unchanged.
> > > 
> > > Siddhesh
> > > 
> > >     	* elf/Makefile (libof-sotruss-lib): Set as extramodules.
> > > 
> > > diff --git a/elf/Makefile b/elf/Makefile
> > > index 677635b..7a5a9aa 100644
> > > --- a/elf/Makefile
> > > +++ b/elf/Makefile
> > > @@ -96,6 +96,7 @@ extra-objs += sotruss-lib.os sotruss-lib.so
> > >  install-others += $(inst_auditdir)/sotruss-lib.so
> > >  install-bin-script += sotruss
> > >  generated += sotruss
> > > +libof-sotruss-lib = extramodules
> > >  CPPFLAGS-sotruss-lib = -DNOT_IN_libc
> > >  $(objpfx)sotruss-lib.so: $(objpfx)sotruss-lib.os
> > >  	$(build-module-asneeded)
> > 
> > 
> 
>
Roland McGrath Nov. 7, 2014, 11:23 p.m. UTC | #4
OK

Patch
diff mbox

diff --git a/elf/Makefile b/elf/Makefile
index 677635b..7a5a9aa 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -96,6 +96,7 @@  extra-objs += sotruss-lib.os sotruss-lib.so
 install-others += $(inst_auditdir)/sotruss-lib.so
 install-bin-script += sotruss
 generated += sotruss
+libof-sotruss-lib = extramodules
 CPPFLAGS-sotruss-lib = -DNOT_IN_libc
 $(objpfx)sotruss-lib.so: $(objpfx)sotruss-lib.os
 	$(build-module-asneeded)