Message ID | 20140917102701.GA5699@hmsreliant.think-freely.org |
---|---|
State | RFC, archived |
Delegated to: | David Miller |
Headers | show |
> Shit, you're right, sorry about that. Its odd, I'm running it here, and its not > causing problems, but thats obviously wrong. Meelis, please add the above fix > to your test and confirm that it sovles the problem. If you could keep the > previous patch in place too that would be great, as we should probably add the > dma error checking anyway. > > > [PATCH] 3c59x: Fix bad offset spec in skb_frag_dma_map Tested 2 variants: only this patch (backported to old state) and both patches together. Both work fine.
On Wed, Sep 17, 2014 at 03:43:54PM +0300, mroos@linux.ee wrote: > > Shit, you're right, sorry about that. Its odd, I'm running it here, and its not > > causing problems, but thats obviously wrong. Meelis, please add the above fix > > to your test and confirm that it sovles the problem. If you could keep the > > previous patch in place too that would be great, as we should probably add the > > dma error checking anyway. > > > > > > [PATCH] 3c59x: Fix bad offset spec in skb_frag_dma_map > > Tested 2 variants: only this patch (backported to old state) and both > patches together. > > Both work fine. > Thank you, Meelis. Dave, I'll propose these patches officially in just a bit sorry for the > -- > Meelis Roos (mroos@linux.ee) > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c index 5621dab..0f59d68 100644 --- a/drivers/net/ethernet/3com/3c59x.c +++ b/drivers/net/ethernet/3com/3c59x.c @@ -2186,7 +2186,7 @@ boomerang_start_xmit(struct sk_buff *skb, struct net_device *dev) skb_frag_t *frag = &skb_shinfo(skb)->frags[i]; dma_addr = skb_frag_dma_map(&VORTEX_PCI(vp)->dev, frag, - frag->page_offset, + 0, frag->size, DMA_TO_DEVICE); if (dma_mapping_error(&VORTEX_PCI(vp)->dev, dma_addr)) {