diff mbox

vnc-tls: Clean up dead store in vnc_set_x509_credential()

Message ID 1410939195-1309-1-git-send-email-armbru@redhat.com
State New
Headers show

Commit Message

Markus Armbruster Sept. 17, 2014, 7:33 a.m. UTC 
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 ui/vnc-tls.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Gerd Hoffmann Sept. 17, 2014, 11:40 a.m. UTC | #1 
On Mi, 2014-09-17 at 09:33 +0200, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  ui/vnc-tls.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c
> index 6392326..0f59f9b 100644
> --- a/ui/vnc-tls.c
> +++ b/ui/vnc-tls.c
> @@ -444,8 +444,6 @@ static int vnc_set_x509_credential(VncDisplay *vd,
>      struct stat sb;
>  
>      g_free(*cred);
> -    *cred = NULL;
> -
>      *cred = g_malloc(strlen(certdir) + strlen(filename) + 2);
>  
>      strcpy(*cred, certdir);

added to vnc patch queue

thanks,
  Gerd
diff mbox

Patch

diff --git a/ui/vnc-tls.c b/ui/vnc-tls.c
index 6392326..0f59f9b 100644
--- a/ui/vnc-tls.c
+++ b/ui/vnc-tls.c
@@ -444,8 +444,6 @@  static int vnc_set_x509_credential(VncDisplay *vd,
     struct stat sb;
 
     g_free(*cred);
-    *cred = NULL;
-
     *cred = g_malloc(strlen(certdir) + strlen(filename) + 2);
 
     strcpy(*cred, certdir);