| Message ID | 20140917053434.2833.66129.stgit@nitbit.x32 |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Please add an appropriate comment to the *code* to prevent this knowledge to disappear. No one will search/find this in git commit messages next time. Tnx Oliver On 17.09.2014 07:34, John Fastabend wrote: > tc_u32_sel 'sel' in tc_u_knode expects to be the last element in the > structure and pads the structure with tc_u32_key fields for each key. > > kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL) > > CC: Eric Dumazet <edumazet@google.com> > Signed-off-by: John Fastabend <john.r.fastabend@intel.com> > --- > net/sched/cls_u32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c > index eceeb04..be24e7e 100644 > --- a/net/sched/cls_u32.c > +++ b/net/sched/cls_u32.c > @@ -64,8 +64,8 @@ struct tc_u_knode { > u32 __percpu *pcpu_success; > #endif > struct tcf_proto *tp; > - struct tc_u32_sel sel; > struct rcu_head rcu; > + struct tc_u32_sel sel; > }; > > struct tc_u_hnode { > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Sep 16, 2014 at 10:54 PM, Oliver Hartkopp <socketcan@hartkopp.net> wrote: > Please add an appropriate comment to the *code* to prevent this knowledge to > disappear. No one will search/find this in git commit messages next time. > +1 Even though I dig git log, I agree adding a one-line comment is better. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/17/2014 09:40 AM, Cong Wang wrote: > On Tue, Sep 16, 2014 at 10:54 PM, Oliver Hartkopp > <socketcan@hartkopp.net> wrote: >> Please add an appropriate comment to the *code* to prevent this knowledge to >> disappear. No one will search/find this in git commit messages next time. >> > > +1 > > Even though I dig git log, I agree adding a one-line comment is better. > Sure I'll add a comment at the end of the structure. Thanks.
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index eceeb04..be24e7e 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@ -64,8 +64,8 @@ struct tc_u_knode { u32 __percpu *pcpu_success; #endif struct tcf_proto *tp; - struct tc_u32_sel sel; struct rcu_head rcu; + struct tc_u32_sel sel; }; struct tc_u_hnode {
tc_u32_sel 'sel' in tc_u_knode expects to be the last element in the structure and pads the structure with tc_u32_key fields for each key. kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL) CC: Eric Dumazet <edumazet@google.com> Signed-off-by: John Fastabend <john.r.fastabend@intel.com> --- net/sched/cls_u32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html