Patchwork [RFC,08/19] powerpc: gamecube/wii: do not include PCI support

login
register
mail settings
Submitter Albert Herranz
Date Nov. 22, 2009, 10:01 p.m.
Message ID <1258927311-4340-9-git-send-email-albert_herranz@yahoo.es>
Download mbox | patch
Permalink /patch/39007/
State Changes Requested
Headers show

Comments

Albert Herranz - Nov. 22, 2009, 10:01 p.m.
The Nintendo GameCube and Wii video game consoles do not have PCI hardware.
Avoid wasting their scarce memory by not including PCI support into the
kernel.

Signed-off-by: Albert Herranz <albert_herranz@yahoo.es>
---
 arch/powerpc/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Grant Likely - Nov. 22, 2009, 11:21 p.m.
On Sun, Nov 22, 2009 at 3:01 PM, Albert Herranz <albert_herranz@yahoo.es> wrote:
> The Nintendo GameCube and Wii video game consoles do not have PCI hardware.
> Avoid wasting their scarce memory by not including PCI support into the
> kernel.
>
> Signed-off-by: Albert Herranz <albert_herranz@yahoo.es>
> ---
>  arch/powerpc/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 2ba14e7..84b2566 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -679,7 +679,7 @@ config PPC_PCI_CHOICE
>  config PCI
>        bool "PCI support" if PPC_PCI_CHOICE
>        default y if !40x && !CPM2 && !8xx && !PPC_83xx \
> -               && !PPC_85xx && !PPC_86xx
> +               && !PPC_85xx && !PPC_86xx && !GAMECUBE_COMMON

phew, this is getting ugly.  But I won't ask you to clean it up.  Ack

g.
Benjamin Herrenschmidt - Nov. 26, 2009, 5:10 a.m.
On Sun, 2009-11-22 at 16:21 -0700, Grant Likely wrote:
> On Sun, Nov 22, 2009 at 3:01 PM, Albert Herranz <albert_herranz@yahoo.es> wrote:
> > The Nintendo GameCube and Wii video game consoles do not have PCI hardware.
> > Avoid wasting their scarce memory by not including PCI support into the
> > kernel.
> >
> > Signed-off-by: Albert Herranz <albert_herranz@yahoo.es>
> > ---
> >  arch/powerpc/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > index 2ba14e7..84b2566 100644
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -679,7 +679,7 @@ config PPC_PCI_CHOICE
> >  config PCI
> >        bool "PCI support" if PPC_PCI_CHOICE
> >        default y if !40x && !CPM2 && !8xx && !PPC_83xx \
> > -               && !PPC_85xx && !PPC_86xx
> > +               && !PPC_85xx && !PPC_86xx && !GAMECUBE_COMMON
> 
> phew, this is getting ugly.  But I won't ask you to clean it up.  Ack

Right. We should have the platforms that want PCI do a select
instead :-)

Cheers,
Ben.

Patch

diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 2ba14e7..84b2566 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -679,7 +679,7 @@  config PPC_PCI_CHOICE
 config PCI
 	bool "PCI support" if PPC_PCI_CHOICE
 	default y if !40x && !CPM2 && !8xx && !PPC_83xx \
-		&& !PPC_85xx && !PPC_86xx
+		&& !PPC_85xx && !PPC_86xx && !GAMECUBE_COMMON
 	default PCI_PERMEDIA if !4xx && !CPM2 && !8xx
 	default PCI_QSPAN if !4xx && !CPM2 && 8xx
 	select ARCH_SUPPORTS_MSI