| Message ID | 20140916063024.2905.55403.stgit@nitbit.x32 |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, Sep 15, 2014 at 11:30 PM, John Fastabend <john.fastabend@gmail.com> wrote: > kbuild test robot reported an unused variable cpu in cls_u32.c > after the patch below. This happens when PERF and MARK config > variables are disabled > > Fix this is to use separate variables for perf and mark > and define the cpu variable inside the ifdef logic. > > 'commit 459d5f626da7 ("net: sched: make cls_u32 per cpu")' Please use the Fixes: tag. > > Signed-off-by: John Fastabend <john.r.fastabend@intel.com> Other than that, Acked-by: Cong Wang <cwang@twopensource.com> Thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: John Fastabend <john.fastabend@gmail.com> Date: Mon, 15 Sep 2014 23:30:26 -0700 > kbuild test robot reported an unused variable cpu in cls_u32.c > after the patch below. This happens when PERF and MARK config > variables are disabled > > Fix this is to use separate variables for perf and mark > and define the cpu variable inside the ifdef logic. > > 'commit 459d5f626da7 ("net: sched: make cls_u32 per cpu")' > > Signed-off-by: John Fastabend <john.r.fastabend@intel.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 5ed5ac4..8cffe5a 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@ -788,8 +788,8 @@ static int u32_dump(struct net *net, struct tcf_proto *tp, unsigned long fh, } else { #ifdef CONFIG_CLS_U32_PERF struct tc_u32_pcnt *gpf; -#endif int cpu; +#endif if (nla_put(skb, TCA_U32_SEL, sizeof(n->sel) + n->sel.nkeys*sizeof(struct tc_u32_key), @@ -816,9 +816,10 @@ static int u32_dump(struct net *net, struct tcf_proto *tp, unsigned long fh, struct tc_u32_mark mark = {.val = n->val, .mask = n->mask, .success = 0}; + int cpum; - for_each_possible_cpu(cpu) { - __u32 cnt = *per_cpu_ptr(n->pcpu_success, cpu); + for_each_possible_cpu(cpum) { + __u32 cnt = *per_cpu_ptr(n->pcpu_success, cpum); mark.success += cnt; }
kbuild test robot reported an unused variable cpu in cls_u32.c after the patch below. This happens when PERF and MARK config variables are disabled Fix this is to use separate variables for perf and mark and define the cpu variable inside the ifdef logic. 'commit 459d5f626da7 ("net: sched: make cls_u32 per cpu")' Signed-off-by: John Fastabend <john.r.fastabend@intel.com> --- net/sched/cls_u32.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html