From patchwork Sun Nov 22 01:07:41 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Nelson X-Patchwork-Id: 38991 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 65DC4B7BCF for ; Sun, 22 Nov 2009 12:07:48 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752256AbZKVBHh (ORCPT ); Sat, 21 Nov 2009 20:07:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752778AbZKVBHh (ORCPT ); Sat, 21 Nov 2009 20:07:37 -0500 Received: from mail-ew0-f219.google.com ([209.85.219.219]:60728 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752256AbZKVBHh (ORCPT ); Sat, 21 Nov 2009 20:07:37 -0500 Received: by ewy19 with SMTP id 19so773958ewy.21 for ; Sat, 21 Nov 2009 17:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:cc:content-type; bh=b+lsmbSP+j5xSCH5c8s7JizM3Ltce2eAYFL+u0LCQsM=; b=J5AI5dFtqJyR07T9MmVJ/ZxRZxEFB4A61ahrD6QgaA6w9EOSkZEBzruYjaucKScFF0 lzkAI3sm+puMpruztcAPieHbDcDiLNHdnFjNwcW9zZIG/iUdj1YSE8UsmHxDAUvvCyQ4 7XTqV/zGWBcWiHzc2Lf/iFsamXfN1oE2t98/E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; b=AvKbh/YUue6OybmehIJoW9xGRCw8v+G+7tJTNQc9OOIoLC+ZMf9IjWbR24zW9kExqz f3hka0Q+ToFYb6Rwoy8gMGNllzaVNzi1fd+Ya0Nkv/G2dVpNpnTn58467pZ/I+owQCOH 0r7+WXvuj5JC0Auh+dlelhVQbxVbAXGIKztHo= MIME-Version: 1.0 Received: by 10.213.0.218 with SMTP id 26mr1927948ebc.19.1258852061733; Sat, 21 Nov 2009 17:07:41 -0800 (PST) Date: Sun, 22 Nov 2009 12:07:41 +1100 Message-ID: <65a6ef750911211707m3cece36fsc464e8e5d9273782@mail.gmail.com> Subject: [PATCH] ahci: let users know that Promise PDC42819 support is limited to SATA devices From: Mark Nelson To: Jeff Garzik Cc: linux-ide@vger.kernel.org Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org ahci can drive the Promise PDC42819, but obviously it can only use SATA disks connected to this controller. The controller can actually support SAS disks as well, but we only know how to use it in it's AHCI mode. Add a message to let users know that because ahci is driving their chip they can only use the SATA disks connected to this controller. Signed-off-by: Mark Nelson --- drivers/ata/ahci.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6/drivers/ata/ahci.c =================================================================== --- linux-2.6.orig/drivers/ata/ahci.c +++ linux-2.6/drivers/ata/ahci.c @@ -2988,6 +2988,14 @@ static int ahci_init_one(struct pci_dev if (pdev->vendor == PCI_VENDOR_ID_MARVELL && !marvell_enable) return -ENODEV; + /* Promise's PDC42819 is a SAS/SATA controller that has an AHCI mode. + * At the moment, we can only use the AHCI mode. Let the users know + * that for SAS drives they're out of luck. + */ + if (pdev->vendor == PCI_VENDOR_ID_PROMISE) + dev_printk(KERN_INFO, &pdev->dev, "PDC42819 " + "can only drive SATA devices with this driver\n"); + /* acquire resources */ rc = pcim_enable_device(pdev); if (rc)