Message ID | 1410818874-6764-1-git-send-email-kamal@canonical.com |
---|---|
State | New |
Headers | show |
On Mon, Sep 15, 2014 at 03:07:54PM -0700, Kamal Mostafa wrote: > This is a note to let you know that I have just added a patch titled > > USB: serial: ftdi_sio: Annotate the current Xsens PID assignments > > to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree > which can be found at: I thought you said you were going to "name" your kernel something else not as confusing as ".y.z" would be? thanks, greg k-h
On Mon, 2014-09-15 at 15:12 -0700, Greg Kroah-Hartman wrote: > On Mon, Sep 15, 2014 at 03:07:54PM -0700, Kamal Mostafa wrote: > > This is a note to let you know that I have just added a patch titled > > > > USB: serial: ftdi_sio: Annotate the current Xsens PID assignments > > > > to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree > > which can be found at: > > I thought you said you were going to "name" your kernel something else > not as confusing as ".y.z" would be? > > thanks, > > greg k-h > Specifically, I said that we would consider it: On Mon, Aug 25, 2014 at 12:14:18PM -0700, Kamal Mostafa wrote: > We'll consider that idea for future extended stable versions maintained > by our team. ... and we are still considering it. -Kamal
On Tue, Sep 16, 2014 at 06:36:54AM -0700, Kamal Mostafa wrote: > On Mon, 2014-09-15 at 15:12 -0700, Greg Kroah-Hartman wrote: > > On Mon, Sep 15, 2014 at 03:07:54PM -0700, Kamal Mostafa wrote: > > > This is a note to let you know that I have just added a patch titled > > > > > > USB: serial: ftdi_sio: Annotate the current Xsens PID assignments > > > > > > to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree > > > which can be found at: > > > > I thought you said you were going to "name" your kernel something else > > not as confusing as ".y.z" would be? > > > > thanks, > > > > greg k-h > > > > > Specifically, I said that we would consider it: > > On Mon, Aug 25, 2014 at 12:14:18PM -0700, Kamal Mostafa wrote: > > We'll consider that idea for future extended stable versions maintained > > by our team. > > ... and we are still considering it. Ok, what does that exactly mean? How long are you going to be "considering it"? Who is doing the "considering"? And why did you strip off the public mailing lists to your response? thanks, greg k-h
On Tue, 2014-09-16 at 07:38 -0700, Greg Kroah-Hartman wrote: > On Tue, Sep 16, 2014 at 06:36:54AM -0700, Kamal Mostafa wrote: > > On Mon, 2014-09-15 at 15:12 -0700, Greg Kroah-Hartman wrote: > > > On Mon, Sep 15, 2014 at 03:07:54PM -0700, Kamal Mostafa wrote: > > > > This is a note to let you know that I have just added a patch titled > > > > > > > > USB: serial: ftdi_sio: Annotate the current Xsens PID assignments > > > > > > > > to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree > > > > which can be found at: > > > > > > I thought you said you were going to "name" your kernel something else > > > not as confusing as ".y.z" would be? > > > > > > thanks, > > > > > > greg k-h > > > > > > > > > Specifically, I said that we would consider it: > > > > On Mon, Aug 25, 2014 at 12:14:18PM -0700, Kamal Mostafa wrote: > > > We'll consider that idea for future extended stable versions maintained > > > by our team. > > > > ... and we are still considering it. > > Ok, what does that exactly mean? It means that we will weigh the costs and benefits of doing so, including: - how much confusion we think our current naming convention actually might causes, or doesn't. - how much confusion changing it would cause for consumers of the kernels we maintain. - the amount of tooling changes it would take to implement such a change. - whether or not we think its a good idea at all. > How long are you going to be "considering it"? Until we reach a conclusion. > Who is doing the "considering"? The Canonical Kernel team. I.e. the people and organization who maintains the kernels you're complaining about. > And why did you strip off the public mailing lists to your response? I did NOT do so, Greg. I stripped off these individuals from the Cc: line, who were present because they were included in the USB patch to which you replied (note the subject line of this thread). These individuals are not likely interested in your version naming issue: Cc: Patrick Riphagen <patrick.riphagen@xsens.com>, Frans Klaver <frans.klaver@xsens.com>, Johan Hovold <johan@kernel.org> The patch message to which you replied was sent to only one list, which I left Cc:'d ( kernel-team@lists.ubuntu.com ). -Kamal > thanks, > > greg k-h >
On Tue, Sep 16, 2014 at 08:02:19AM -0700, Kamal Mostafa wrote: > On Tue, 2014-09-16 at 07:38 -0700, Greg Kroah-Hartman wrote: > > On Tue, Sep 16, 2014 at 06:36:54AM -0700, Kamal Mostafa wrote: > > > On Mon, 2014-09-15 at 15:12 -0700, Greg Kroah-Hartman wrote: > > > > On Mon, Sep 15, 2014 at 03:07:54PM -0700, Kamal Mostafa wrote: > > > > > This is a note to let you know that I have just added a patch titled > > > > > > > > > > USB: serial: ftdi_sio: Annotate the current Xsens PID assignments > > > > > > > > > > to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree > > > > > which can be found at: > > > > > > > > I thought you said you were going to "name" your kernel something else > > > > not as confusing as ".y.z" would be? > > > > > > > > thanks, > > > > > > > > greg k-h > > > > > > > > > > > > > Specifically, I said that we would consider it: > > > > > > On Mon, Aug 25, 2014 at 12:14:18PM -0700, Kamal Mostafa wrote: > > > > We'll consider that idea for future extended stable versions maintained > > > > by our team. > > > > > > ... and we are still considering it. > > > > Ok, what does that exactly mean? > > It means that we will weigh the costs and benefits of doing so, > including: > - how much confusion we think our current naming convention actually > might causes, or doesn't. > - how much confusion changing it would cause for consumers of the > kernels we maintain. Any idea how you will be doing this? > - the amount of tooling changes it would take to implement such a > change. > - whether or not we think its a good idea at all. Lovely squishy things :) > > How long are you going to be "considering it"? > > Until we reach a conclusion. Any specific timeframe? > > Who is doing the "considering"? > > The Canonical Kernel team. I.e. the people and organization who > maintains the kernels you're complaining about. I'm only "complaining" about the version number, not the work happening. > > And why did you strip off the public mailing lists to your response? > > I did NOT do so, Greg. I stripped off these individuals from the Cc: > line, who were present because they were included in the USB patch to > which you replied (note the subject line of this thread). These > individuals are not likely interested in your version naming issue: > > Cc: Patrick Riphagen <patrick.riphagen@xsens.com>, > Frans Klaver <frans.klaver@xsens.com>, > Johan Hovold <johan@kernel.org> > > The patch message to which you replied was sent to only one list, which > I left Cc:'d ( kernel-team@lists.ubuntu.com ). My fault, you set the reply-to on the original patch to go to this list, which my email client rightfully chose. Sorry for the statement, I was wrong. thanks, greg k-h
diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h index c4777bc..3fc7897 100644 --- a/drivers/usb/serial/ftdi_sio_ids.h +++ b/drivers/usb/serial/ftdi_sio_ids.h @@ -140,12 +140,12 @@ /* * Xsens Technologies BV products (http://www.xsens.com). */ -#define XSENS_CONVERTER_0_PID 0xD388 -#define XSENS_CONVERTER_1_PID 0xD389 +#define XSENS_CONVERTER_0_PID 0xD388 /* Xsens USB converter */ +#define XSENS_CONVERTER_1_PID 0xD389 /* Xsens Wireless Receiver */ #define XSENS_CONVERTER_2_PID 0xD38A -#define XSENS_CONVERTER_3_PID 0xD38B -#define XSENS_CONVERTER_4_PID 0xD38C -#define XSENS_CONVERTER_5_PID 0xD38D +#define XSENS_CONVERTER_3_PID 0xD38B /* Xsens USB-serial converter */ +#define XSENS_CONVERTER_4_PID 0xD38C /* Xsens Wireless Receiver */ +#define XSENS_CONVERTER_5_PID 0xD38D /* Xsens Awinda Station */ #define XSENS_CONVERTER_6_PID 0xD38E #define XSENS_CONVERTER_7_PID 0xD38F