diff mbox

[3.13.y.z,extended,stable] Patch "USB: serial: ftdi_sio: Annotate the current Xsens PID assignments" has been added to staging queue

Message ID 1410818874-6764-1-git-send-email-kamal@canonical.com
State New
Headers show

Commit Message

Kamal Mostafa Sept. 15, 2014, 10:07 p.m. UTC
This is a note to let you know that I have just added a patch titled

    USB: serial: ftdi_sio: Annotate the current Xsens PID assignments

to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree 
which can be found at:

 http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/linux-3.13.y-queue

This patch is scheduled to be released in version 3.13.11.7.

If you, or anyone else, feels it should not be added to this tree, please 
reply to this email.

For more information about the 3.13.y.z tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable

Thanks.
-Kamal

------

From d49e62c46b59911ef31819085c675a24c1326759 Mon Sep 17 00:00:00 2001
From: Patrick Riphagen <patrick.riphagen@xsens.com>
Date: Thu, 24 Jul 2014 09:12:52 +0200
Subject: USB: serial: ftdi_sio: Annotate the current Xsens PID assignments

commit 9273b8a270878906540349422ab24558b9d65716 upstream.

The converters are used in specific products. It can be useful to know
which they are exactly.

Signed-off-by: Patrick Riphagen <patrick.riphagen@xsens.com>
Signed-off-by: Frans Klaver <frans.klaver@xsens.com>
Cc: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
---
 drivers/usb/serial/ftdi_sio_ids.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

--
1.9.1

Comments

gregkh@linuxfoundation.org Sept. 15, 2014, 10:12 p.m. UTC | #1
On Mon, Sep 15, 2014 at 03:07:54PM -0700, Kamal Mostafa wrote:
> This is a note to let you know that I have just added a patch titled
> 
>     USB: serial: ftdi_sio: Annotate the current Xsens PID assignments
> 
> to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree 
> which can be found at:

I thought you said you were going to "name" your kernel something else
not as confusing as ".y.z" would be?

thanks,

greg k-h
Kamal Mostafa Sept. 16, 2014, 1:36 p.m. UTC | #2
On Mon, 2014-09-15 at 15:12 -0700, Greg Kroah-Hartman wrote:
> On Mon, Sep 15, 2014 at 03:07:54PM -0700, Kamal Mostafa wrote:
> > This is a note to let you know that I have just added a patch titled
> > 
> >     USB: serial: ftdi_sio: Annotate the current Xsens PID assignments
> > 
> > to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree 
> > which can be found at:
> 
> I thought you said you were going to "name" your kernel something else
> not as confusing as ".y.z" would be?
> 
> thanks,
> 
> greg k-h
> 


Specifically, I said that we would consider it:

On Mon, Aug 25, 2014 at 12:14:18PM -0700, Kamal Mostafa wrote:
> We'll consider that idea for future extended stable versions maintained
> by our team.

... and we are still considering it.

 -Kamal
gregkh@linuxfoundation.org Sept. 16, 2014, 2:38 p.m. UTC | #3
On Tue, Sep 16, 2014 at 06:36:54AM -0700, Kamal Mostafa wrote:
> On Mon, 2014-09-15 at 15:12 -0700, Greg Kroah-Hartman wrote:
> > On Mon, Sep 15, 2014 at 03:07:54PM -0700, Kamal Mostafa wrote:
> > > This is a note to let you know that I have just added a patch titled
> > > 
> > >     USB: serial: ftdi_sio: Annotate the current Xsens PID assignments
> > > 
> > > to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree 
> > > which can be found at:
> > 
> > I thought you said you were going to "name" your kernel something else
> > not as confusing as ".y.z" would be?
> > 
> > thanks,
> > 
> > greg k-h
> > 
> 
> 
> Specifically, I said that we would consider it:
> 
> On Mon, Aug 25, 2014 at 12:14:18PM -0700, Kamal Mostafa wrote:
> > We'll consider that idea for future extended stable versions maintained
> > by our team.
> 
> ... and we are still considering it.

Ok, what does that exactly mean?  How long are you going to be
"considering it"?  Who is doing the "considering"?

And why did you strip off the public mailing lists to your response?

thanks,

greg k-h
Kamal Mostafa Sept. 16, 2014, 3:02 p.m. UTC | #4
On Tue, 2014-09-16 at 07:38 -0700, Greg Kroah-Hartman wrote:
> On Tue, Sep 16, 2014 at 06:36:54AM -0700, Kamal Mostafa wrote:
> > On Mon, 2014-09-15 at 15:12 -0700, Greg Kroah-Hartman wrote:
> > > On Mon, Sep 15, 2014 at 03:07:54PM -0700, Kamal Mostafa wrote:
> > > > This is a note to let you know that I have just added a patch titled
> > > > 
> > > >     USB: serial: ftdi_sio: Annotate the current Xsens PID assignments
> > > > 
> > > > to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree 
> > > > which can be found at:
> > > 
> > > I thought you said you were going to "name" your kernel something else
> > > not as confusing as ".y.z" would be?
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > 
> > 
> > 
> > Specifically, I said that we would consider it:
> > 
> > On Mon, Aug 25, 2014 at 12:14:18PM -0700, Kamal Mostafa wrote:
> > > We'll consider that idea for future extended stable versions maintained
> > > by our team.
> > 
> > ... and we are still considering it.
> 
> Ok, what does that exactly mean?

It means that we will weigh the costs and benefits of doing so,
including:
 - how much confusion we think our current naming convention actually
might causes, or doesn't.
 - how much confusion changing it would cause for consumers of the
kernels we maintain.
 - the amount of tooling changes it would take to implement such a
change.
 - whether or not we think its a good idea at all.


>   How long are you going to be "considering it"?

Until we reach a conclusion.


>   Who is doing the "considering"?

The Canonical Kernel team.  I.e. the people and organization who
maintains the kernels you're complaining about.


> And why did you strip off the public mailing lists to your response?

I did NOT do so, Greg.  I stripped off these individuals from the Cc:
line, who were present because they were included in the USB patch to
which you replied (note the subject line of this thread).  These
individuals are not likely interested in your version naming issue:

        Cc:	Patrick Riphagen <patrick.riphagen@xsens.com>,
         Frans Klaver <frans.klaver@xsens.com>,
         Johan Hovold <johan@kernel.org>

The patch message to which you replied was sent to only one list, which
I left Cc:'d ( kernel-team@lists.ubuntu.com ).

 -Kamal


> thanks,
> 
> greg k-h
>
gregkh@linuxfoundation.org Sept. 16, 2014, 5:49 p.m. UTC | #5
On Tue, Sep 16, 2014 at 08:02:19AM -0700, Kamal Mostafa wrote:
> On Tue, 2014-09-16 at 07:38 -0700, Greg Kroah-Hartman wrote:
> > On Tue, Sep 16, 2014 at 06:36:54AM -0700, Kamal Mostafa wrote:
> > > On Mon, 2014-09-15 at 15:12 -0700, Greg Kroah-Hartman wrote:
> > > > On Mon, Sep 15, 2014 at 03:07:54PM -0700, Kamal Mostafa wrote:
> > > > > This is a note to let you know that I have just added a patch titled
> > > > > 
> > > > >     USB: serial: ftdi_sio: Annotate the current Xsens PID assignments
> > > > > 
> > > > > to the linux-3.13.y-queue branch of the 3.13.y.z extended stable tree 
> > > > > which can be found at:
> > > > 
> > > > I thought you said you were going to "name" your kernel something else
> > > > not as confusing as ".y.z" would be?
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > > 
> > > 
> > > 
> > > Specifically, I said that we would consider it:
> > > 
> > > On Mon, Aug 25, 2014 at 12:14:18PM -0700, Kamal Mostafa wrote:
> > > > We'll consider that idea for future extended stable versions maintained
> > > > by our team.
> > > 
> > > ... and we are still considering it.
> > 
> > Ok, what does that exactly mean?
> 
> It means that we will weigh the costs and benefits of doing so,
> including:
>  - how much confusion we think our current naming convention actually
> might causes, or doesn't.
>  - how much confusion changing it would cause for consumers of the
> kernels we maintain.

Any idea how you will be doing this?

>  - the amount of tooling changes it would take to implement such a
> change.
>  - whether or not we think its a good idea at all.

Lovely squishy things :)

> >   How long are you going to be "considering it"?
> 
> Until we reach a conclusion.

Any specific timeframe?

> >   Who is doing the "considering"?
> 
> The Canonical Kernel team.  I.e. the people and organization who
> maintains the kernels you're complaining about.

I'm only "complaining" about the version number, not the work happening.

> > And why did you strip off the public mailing lists to your response?
> 
> I did NOT do so, Greg.  I stripped off these individuals from the Cc:
> line, who were present because they were included in the USB patch to
> which you replied (note the subject line of this thread).  These
> individuals are not likely interested in your version naming issue:
> 
>         Cc:	Patrick Riphagen <patrick.riphagen@xsens.com>,
>          Frans Klaver <frans.klaver@xsens.com>,
>          Johan Hovold <johan@kernel.org>
> 
> The patch message to which you replied was sent to only one list, which
> I left Cc:'d ( kernel-team@lists.ubuntu.com ).

My fault, you set the reply-to on the original patch to go to this list,
which my email client rightfully chose.  Sorry for the statement, I was
wrong.

thanks,

greg k-h
diff mbox

Patch

diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
index c4777bc..3fc7897 100644
--- a/drivers/usb/serial/ftdi_sio_ids.h
+++ b/drivers/usb/serial/ftdi_sio_ids.h
@@ -140,12 +140,12 @@ 
 /*
  * Xsens Technologies BV products (http://www.xsens.com).
  */
-#define XSENS_CONVERTER_0_PID	0xD388
-#define XSENS_CONVERTER_1_PID	0xD389
+#define XSENS_CONVERTER_0_PID	0xD388	/* Xsens USB converter */
+#define XSENS_CONVERTER_1_PID	0xD389	/* Xsens Wireless Receiver */
 #define XSENS_CONVERTER_2_PID	0xD38A
-#define XSENS_CONVERTER_3_PID	0xD38B
-#define XSENS_CONVERTER_4_PID	0xD38C
-#define XSENS_CONVERTER_5_PID	0xD38D
+#define XSENS_CONVERTER_3_PID	0xD38B	/* Xsens USB-serial converter */
+#define XSENS_CONVERTER_4_PID	0xD38C	/* Xsens Wireless Receiver */
+#define XSENS_CONVERTER_5_PID	0xD38D	/* Xsens Awinda Station */
 #define XSENS_CONVERTER_6_PID	0xD38E
 #define XSENS_CONVERTER_7_PID	0xD38F