Message ID | 1410815210-6693-4-git-send-email-xiyou.wangcong@gmail.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On 09/15/2014 02:06 PM, Cong Wang wrote: > This patch fixes the following kernel warning: > > [ 44.805900] [ INFO: suspicious RCU usage. ] > [ 44.808946] 3.17.0-rc4+ #610 Not tainted > [ 44.811831] ------------------------------- > [ 44.814873] net/sched/cls_tcindex.c:84 suspicious rcu_dereference_check() usage! > > Fixes: commit 331b72922c5f58d48fd ("net: sched: RCU cls_tcindex") > Cc: John Fastabend <john.fastabend@gmail.com> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> > --- > net/sched/cls_tcindex.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c > index 16ec1ed..f276de5 100644 > --- a/net/sched/cls_tcindex.c > +++ b/net/sched/cls_tcindex.c > @@ -81,7 +81,7 @@ tcindex_lookup(struct tcindex_data *p, u16 key) > static int tcindex_classify(struct sk_buff *skb, const struct tcf_proto *tp, > struct tcf_result *res) > { > - struct tcindex_data *p = rcu_dereference(tp->root); > + struct tcindex_data *p = rcu_dereference_bh(tp->root); > struct tcindex_filter_result *f; > int key = (skb->tc_index & p->mask) >> p->shift; > > Thanks for catching/fixing. I also missed cls_bpf.c case I'll send a fix in a moment. Acked-by: John Fastabend <john.r.fastabend@intel.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Cong Wang <xiyou.wangcong@gmail.com> Date: Mon, 15 Sep 2014 14:06:48 -0700 > This patch fixes the following kernel warning: > > [ 44.805900] [ INFO: suspicious RCU usage. ] > [ 44.808946] 3.17.0-rc4+ #610 Not tainted > [ 44.811831] ------------------------------- > [ 44.814873] net/sched/cls_tcindex.c:84 suspicious rcu_dereference_check() usage! > > Fixes: commit 331b72922c5f58d48fd ("net: sched: RCU cls_tcindex") > Cc: John Fastabend <john.fastabend@gmail.com> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c index 16ec1ed..f276de5 100644 --- a/net/sched/cls_tcindex.c +++ b/net/sched/cls_tcindex.c @@ -81,7 +81,7 @@ tcindex_lookup(struct tcindex_data *p, u16 key) static int tcindex_classify(struct sk_buff *skb, const struct tcf_proto *tp, struct tcf_result *res) { - struct tcindex_data *p = rcu_dereference(tp->root); + struct tcindex_data *p = rcu_dereference_bh(tp->root); struct tcindex_filter_result *f; int key = (skb->tc_index & p->mask) >> p->shift;
This patch fixes the following kernel warning: [ 44.805900] [ INFO: suspicious RCU usage. ] [ 44.808946] 3.17.0-rc4+ #610 Not tainted [ 44.811831] ------------------------------- [ 44.814873] net/sched/cls_tcindex.c:84 suspicious rcu_dereference_check() usage! Fixes: commit 331b72922c5f58d48fd ("net: sched: RCU cls_tcindex") Cc: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> --- net/sched/cls_tcindex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)