From patchwork Fri Nov 20 22:23:03 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Lock X-Patchwork-Id: 38946 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AC4B61007D2 for ; Sat, 21 Nov 2009 11:07:46 +1100 (EST) Received: from localhost ([127.0.0.1]:36152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBdVu-0002kg-HQ for incoming@patchwork.ozlabs.org; Fri, 20 Nov 2009 19:07:42 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NBdPS-0000AZ-4E for qemu-devel@nongnu.org; Fri, 20 Nov 2009 19:01:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NBdPP-00008Y-F1 for qemu-devel@nongnu.org; Fri, 20 Nov 2009 19:01:00 -0500 Received: from [199.232.76.173] (port=33128 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NBdPP-00008S-8o for qemu-devel@nongnu.org; Fri, 20 Nov 2009 19:00:59 -0500 Received: from gelbbaer.kn-bremen.de ([78.46.108.116]:58282 helo=smtp.kn-bremen.de) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NBdPO-0000OU-MB for qemu-devel@nongnu.org; Fri, 20 Nov 2009 19:00:58 -0500 Received: by smtp.kn-bremen.de (Postfix, from userid 10) id CA0891E00715; Sat, 21 Nov 2009 01:00:56 +0100 (CET) Received: from triton8.kn-bremen.de (noident@localhost [127.0.0.1]) by triton8.kn-bremen.de (8.14.3/8.14.3) with ESMTP id nAKMN4pT016508 for ; Fri, 20 Nov 2009 23:23:04 +0100 (CET) (envelope-from nox@triton8.kn-bremen.de) Received: (from nox@localhost) by triton8.kn-bremen.de (8.14.3/8.14.3/Submit) id nAKMN4wv016507 for qemu-devel@nongnu.org; Fri, 20 Nov 2009 23:23:04 +0100 (CET) (envelope-from nox) From: Juergen Lock Date: Fri, 20 Nov 2009 23:23:03 +0100 To: qemu-devel@nongnu.org Message-ID: <20091120222303.GA16486@triton8.kn-bremen.de> References: <20091120221953.GA16319@triton8.kn-bremen.de> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: [Qemu-devel] [PATCH 2/3] Avoid segfault on net_tap_init() failure X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Check for fd == -1 there. Signed-off-by: Juergen Lock --- a/net/tap.c +++ b/net/tap.c @@ -400,6 +400,9 @@ int net_init_tap(QemuOpts *opts, Monitor } fd = net_tap_init(opts, &vnet_hdr); + if (fd == -1) { + return -1; + } } s = net_tap_fd_init(vlan, "tap", name, fd, vnet_hdr);