| Message ID | 1410785865-27946-8-git-send-email-sjg@chromium.org |
|---|---|
| State | Superseded |
| Delegated to: | Simon Glass |
| Headers | show |
On 09/15/14 15:57, Simon Glass wrote: > This seems to break mkimage: > > Invalid imximage commands Type - valid names are: BOOT_FROM, BOOT_OFFSET, DATA, CSF, IMAGE_VERSION > Error: board/compulab/cm_fx6/imximage.cfg[1] - Invalid command(/*) That is really strange, because there are multiple imximage.cfg files with headers like this and I don't remember any complaints. Also, I've checked right now on v2014.10-rc2 + Nikita's patches on top and no problem has occurred. What are you basing at? > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > board/compulab/cm_fx6/imximage.cfg | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/board/compulab/cm_fx6/imximage.cfg b/board/compulab/cm_fx6/imximage.cfg > index 420947e..95e27be 100644 > --- a/board/compulab/cm_fx6/imximage.cfg > +++ b/board/compulab/cm_fx6/imximage.cfg > @@ -1,8 +1,2 @@ > -/* > - * Copyright (C) 2014, Compulab Ltd - http://compulab.co.il/ > - * > - * SPDX-License-Identifier: GPL-2.0+ > - */ > - > IMAGE_VERSION 2 > BOOT_FROM sd >
Hi Igor, On 15 September 2014 12:00, Igor Grinberg <grinberg@compulab.co.il> wrote: > On 09/15/14 15:57, Simon Glass wrote: > > This seems to break mkimage: > > > > Invalid imximage commands Type - valid names are: BOOT_FROM, > BOOT_OFFSET, DATA, CSF, IMAGE_VERSION > > Error: board/compulab/cm_fx6/imximage.cfg[1] - Invalid command(/*) > > That is really strange, because there are multiple imximage.cfg > files with headers like this and I don't remember any complaints. > > Also, I've checked right now on v2014.10-rc2 + Nikita's patches on top > and no problem has occurred. > > What are you basing at? > I am using master at u-boot-imx. I'll drop this patch for v2, but I need it locally for now. > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > board/compulab/cm_fx6/imximage.cfg | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/board/compulab/cm_fx6/imximage.cfg > b/board/compulab/cm_fx6/imximage.cfg > > index 420947e..95e27be 100644 > > --- a/board/compulab/cm_fx6/imximage.cfg > > +++ b/board/compulab/cm_fx6/imximage.cfg > > @@ -1,8 +1,2 @@ > > -/* > > - * Copyright (C) 2014, Compulab Ltd - http://compulab.co.il/ > > - * > > - * SPDX-License-Identifier: GPL-2.0+ > > - */ > > - > > IMAGE_VERSION 2 > > BOOT_FROM sd > > > > -- > Regards, > Igor. > Regards, Simon
diff --git a/board/compulab/cm_fx6/imximage.cfg b/board/compulab/cm_fx6/imximage.cfg index 420947e..95e27be 100644 --- a/board/compulab/cm_fx6/imximage.cfg +++ b/board/compulab/cm_fx6/imximage.cfg @@ -1,8 +1,2 @@ -/* - * Copyright (C) 2014, Compulab Ltd - http://compulab.co.il/ - * - * SPDX-License-Identifier: GPL-2.0+ - */ - IMAGE_VERSION 2 BOOT_FROM sd
This seems to break mkimage: Invalid imximage commands Type - valid names are: BOOT_FROM, BOOT_OFFSET, DATA, CSF, IMAGE_VERSION Error: board/compulab/cm_fx6/imximage.cfg[1] - Invalid command(/*) Signed-off-by: Simon Glass <sjg@chromium.org> --- board/compulab/cm_fx6/imximage.cfg | 6 ------ 1 file changed, 6 deletions(-)