Message ID | 1410775594-3129-1-git-send-email-mike.looijmans@topic.nl |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
I based this patch on the 3.17rc5 state. Hope this applies cleanly now? On 09/15/2014 12:06 PM, Mike Looijmans wrote: > The KSZ9031 appears to suffer from the same hardware bug as described > for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577 > ("net/phy: micrel: Disable asymmetric pause for KSZ9021") > you have to unplug the cable and plug it back to get it to work. > > Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > --- > drivers/net/phy/micrel.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index fd0ea7c..011dbda 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -592,8 +592,7 @@ static struct phy_driver ksphy_driver[] = { > .phy_id = PHY_ID_KSZ9031, > .phy_id_mask = 0x00fffff0, > .name = "Micrel KSZ9031 Gigabit PHY", > - .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause > - | SUPPORTED_Asym_Pause), > + .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause), > .flags = PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT, > .config_init = ksz9031_config_init, > .config_aneg = genphy_config_aneg, > Met vriendelijke groet / kind regards, Mike Looijmans TOPIC Embedded Systems Eindhovenseweg 32-C, NL-5683 KH Best Postbus 440, NL-5680 AK Best Telefoon: (+31) (0) 499 33 69 79 Telefax: (+31) (0) 499 33 69 70 E-mail: mike.looijmans@topic.nl Website: www.topic.nl Please consider the environment before printing this e-mail Topic zoekt gedreven (embedded) software specialisten! http://topic.nl/vacatures/topic-zoekt-software-engineers/ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Mike Looijmans <mike.looijmans@topic.nl> Date: Mon, 15 Sep 2014 12:06:33 +0200 > The KSZ9031 appears to suffer from the same hardware bug as described > for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577 > ("net/phy: micrel: Disable asymmetric pause for KSZ9021") > you have to unplug the cable and plug it back to get it to work. > > Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index fd0ea7c..011dbda 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -592,8 +592,7 @@ static struct phy_driver ksphy_driver[] = { .phy_id = PHY_ID_KSZ9031, .phy_id_mask = 0x00fffff0, .name = "Micrel KSZ9031 Gigabit PHY", - .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause - | SUPPORTED_Asym_Pause), + .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause), .flags = PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT, .config_init = ksz9031_config_init, .config_aneg = genphy_config_aneg,
The KSZ9031 appears to suffer from the same hardware bug as described for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577 ("net/phy: micrel: Disable asymmetric pause for KSZ9021") you have to unplug the cable and plug it back to get it to work. Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this. Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> --- drivers/net/phy/micrel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)