diff mbox

[1/2] pkg-infra: put optional step_user def and assignment in one block

Message ID 1410578043-10682-1-git-send-email-danomimanchego123@gmail.com
State Superseded
Headers show

Commit Message

Danomi Manchego Sept. 13, 2014, 3:14 a.m. UTC
Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>

---

Like the manual says in 'The .mk file' section ...

Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
 package/pkg-generic.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN Sept. 14, 2014, 10:08 p.m. UTC | #1
Danomi, All,

On 2014-09-12 23:14 -0400, Danomi Manchego spake thusly:
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> 
> Like the manual says in 'The .mk file' section ...
> 
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
> ---
>  package/pkg-generic.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index d04fd36..4b6d818 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -56,11 +56,11 @@ endef
>  GLOBAL_INSTRUMENTATION_HOOKS += step_time
>  
>  # User-supplied script
> +ifneq ($(BR2_INSTRUMENTATION_SCRIPTS),)
>  define step_user
>  	@$(foreach user_hook, $(BR2_INSTRUMENTATION_SCRIPTS), \
>  		$(EXTRA_ENV) $(user_hook) "$(1)" "$(2)" "$(3)"$(sep))
>  endef
> -ifneq ($(BR2_INSTRUMENTATION_SCRIPTS),)
>  GLOBAL_INSTRUMENTATION_HOOKS += step_user
>  endif
>  
> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index d04fd36..4b6d818 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -56,11 +56,11 @@  endef
 GLOBAL_INSTRUMENTATION_HOOKS += step_time
 
 # User-supplied script
+ifneq ($(BR2_INSTRUMENTATION_SCRIPTS),)
 define step_user
 	@$(foreach user_hook, $(BR2_INSTRUMENTATION_SCRIPTS), \
 		$(EXTRA_ENV) $(user_hook) "$(1)" "$(2)" "$(3)"$(sep))
 endef
-ifneq ($(BR2_INSTRUMENTATION_SCRIPTS),)
 GLOBAL_INSTRUMENTATION_HOOKS += step_user
 endif