| Message ID | 1410537011-29662-9-git-send-email-jezz@sysmic.org |
|---|---|
| State | Accepted |
| Headers | show |
>>>>> "Jérôme" == Jérôme Pouiller <jezz@sysmic.org> writes: > Fixes http://sysmic.org/~jezz/results/17f32103: > xfs_fsr.o: In function `fsrallfs': > /home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/fsr/xfs_fsr.c:617: undefined reference to `_fork' > collect2: ld returned 1 exit status > madvise.o: In function `madvise_f': > /home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/io/madvise.c:111: undefined reference to `_madvise' > mincore.o: In function `mincore_f': > /home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/io/mincore.c:77: undefined reference to `_mincore' > collect2: ld returned 1 exit status > Signed-off-by: Jérôme Pouiller <jezz@sysmic.org> > --- > package/xfsprogs/Config.in | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > diff --git a/package/xfsprogs/Config.in b/package/xfsprogs/Config.in > index 3a31dd2..bb7634c 100644 > --- a/package/xfsprogs/Config.in > +++ b/package/xfsprogs/Config.in > @@ -2,11 +2,12 @@ > comment "Note that xfsprogs needs a toolchain with UCLIBC_SV4_DEPRECATED and UCLIBC_HAS_OBSOLETE_BSD_SIGNAL enabled" > depends on BR2_PACKAGE_XFSPROGS > -comment "xfsprogs needs a toolchain w/ largefile, wchar" > - depends on !(BR2_LARGEFILE && BR2_USE_WCHAR) > +comment "xfsprogs needs a toolchain w/ largefile, wchar, MMU" > + depends on !(BR2_LARGEFILE && BR2_USE_WCHAR && BR2_USE_MMU) The user typically cannot do anything about the MMU dependency, so we don't add it to the comment line (but do make the comment depend on MMU so it's only shown for people who can use it). Committed with that fixed, thanks.
diff --git a/package/xfsprogs/Config.in b/package/xfsprogs/Config.in index 3a31dd2..bb7634c 100644 --- a/package/xfsprogs/Config.in +++ b/package/xfsprogs/Config.in @@ -2,11 +2,12 @@ comment "Note that xfsprogs needs a toolchain with UCLIBC_SV4_DEPRECATED and UCLIBC_HAS_OBSOLETE_BSD_SIGNAL enabled" depends on BR2_PACKAGE_XFSPROGS -comment "xfsprogs needs a toolchain w/ largefile, wchar" - depends on !(BR2_LARGEFILE && BR2_USE_WCHAR) +comment "xfsprogs needs a toolchain w/ largefile, wchar, MMU" + depends on !(BR2_LARGEFILE && BR2_USE_WCHAR && BR2_USE_MMU) config BR2_PACKAGE_XFSPROGS bool "xfsprogs" + depends on BR2_USE_MMU # fork() depends on BR2_LARGEFILE depends on BR2_USE_WCHAR # util-linux select BR2_PACKAGE_UTIL_LINUX
Fixes http://sysmic.org/~jezz/results/17f32103: xfs_fsr.o: In function `fsrallfs': /home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/fsr/xfs_fsr.c:617: undefined reference to `_fork' collect2: ld returned 1 exit status madvise.o: In function `madvise_f': /home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/io/madvise.c:111: undefined reference to `_madvise' mincore.o: In function `mincore_f': /home/jezz/br-continuous/cfgs/45-bf609-bfin-uclibc-nommu-ext/build/xfsprogs-3.1.11/io/mincore.c:77: undefined reference to `_mincore' collect2: ld returned 1 exit status Signed-off-by: Jérôme Pouiller <jezz@sysmic.org> --- package/xfsprogs/Config.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)