| Message ID | 1410465381-27916-1-git-send-email-yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Commit | 21c8f1e9470d37787b6d7cef10612df56cfdef2a |
| Headers | show |
Dear Yann E. MORIN, Minor typo in title: atmoics -> atomics. On Thu, 11 Sep 2014 21:56:21 +0200, Yann E. MORIN wrote: > Due to a kconfig limitation, we can't select a no-prompt symbol that > gets its dependencies by be conditionally re-defined in one or more "by be" ? > if-blocks, like we currently do for BR2_ARCH_HAS_ATOMICS. > > As a workaround to this issue, we just redefine that symbol in the arc > if-block, like we do for all other archtectures, except that in the arc architectures > case, the default value is conditional. > > Reported-by: Anton Kolesov <Anton.Kolesov@synopsys.com> > [yann.morin.1998@free.fr: indepently re-done a patch similar to the one > Thomas made on his own] > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Thomas
Thomas, All, On 2014-09-11 22:34 +0200, Thomas Petazzoni spake thusly: > Minor typo in title: atmoics -> atomics. Eh... > On Thu, 11 Sep 2014 21:56:21 +0200, Yann E. MORIN wrote: > > Due to a kconfig limitation, we can't select a no-prompt symbol that > > gets its dependencies by be conditionally re-defined in one or more > > "by be" ? by being... > > if-blocks, like we currently do for BR2_ARCH_HAS_ATOMICS. > > > > As a workaround to this issue, we just redefine that symbol in the arc > > if-block, like we do for all other archtectures, except that in the arc > > architectures OK. Will re-spin. Thans! Regards, Yann E. MORIN. > > case, the default value is conditional. > > > > Reported-by: Anton Kolesov <Anton.Kolesov@synopsys.com> > > [yann.morin.1998@free.fr: indepently re-done a patch similar to the one > > Thomas made on his own] > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
diff --git a/arch/Config.in.arc b/arch/Config.in.arc index 8a7f290..fcb5d7d 100644 --- a/arch/Config.in.arc +++ b/arch/Config.in.arc @@ -1,7 +1,9 @@ # Choise of atomic instructions presence config BR2_ARC_ATOMIC_EXT bool "Atomic extension (LLOCK/SCOND instructions)" - select BR2_ARCH_HAS_ATOMICS + +config BR2_ARCH_HAS_ATOMICS + default y if BR2_ARC_ATOMIC_EXT config BR2_ARCH default "arc" if BR2_arcle
Due to a kconfig limitation, we can't select a no-prompt symbol that gets its dependencies by be conditionally re-defined in one or more if-blocks, like we currently do for BR2_ARCH_HAS_ATOMICS. As a workaround to this issue, we just redefine that symbol in the arc if-block, like we do for all other archtectures, except that in the arc case, the default value is conditional. Reported-by: Anton Kolesov <Anton.Kolesov@synopsys.com> [yann.morin.1998@free.fr: indepently re-done a patch similar to the one Thomas made on his own] Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- arch/Config.in.arc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)