Patchwork Bug in drivers/serial/of_serial.c?

login
register
mail settings
Submitter Alon Ziv
Date Nov. 19, 2009, 1:32 p.m.
Message ID <8B957E110B62714A84290A01A597805F05D2AE44@Exchange.discretix.com>
Download mbox | patch
Permalink /patch/38833/
State Superseded
Headers show

Comments

Alon Ziv - Nov. 19, 2009, 1:32 p.m.
Hi,

On Thursday, November 19, 2009, Arnd wrote:
> In that case, add another entry for the device encoded in the firmware
> itself. The ns16550 entry should be the second one after a more
specific
> one telling which device it is exactly.
> 

Is the following better?

---
[PATCH] Xilinx 16550 UART is actually 16550A-compatible

.data = (void *)PORT_16550A, },
 	{ .type = "serial", .compatible = "ns16550",  .data = (void
*)PORT_16550, },
 	{ .type = "serial", .compatible = "ns16750",  .data = (void
*)PORT_16750, },
 	{ .type = "serial", .compatible = "ns16850",  .data = (void
*)PORT_16850, },
**********************************************************************************************
IMPORTANT: The contents of this email and any attachments are confidential. They are intended for the 
named recipient(s) only.
If you have received this email in error, please notify the system manager or the sender immediately and do 
not disclose the contents to anyone or make copies thereof.
Arnd Bergmann - Nov. 19, 2009, 1:41 p.m.
On Thursday 19 November 2009, Alon Ziv wrote:
> Is the following better?
> 
> ---
> [PATCH] Xilinx 16550 UART is actually 16550A-compatible
> 

Yes, that's better because it's guaranteed not to break any
other system, while fixing yours.

I'd still add support for the compatible="ns16550a" property
so that we do the right thing for future systems.

	Arnd <><

Patch

diff --git a/drivers/serial/of_serial.c b/drivers/serial/of_serial.c
index 02406ba..40bf8f4 100644
--- a/drivers/serial/of_serial.c
+++ b/drivers/serial/of_serial.c
@@ -161,6 +161,7 @@  static int of_platform_serial_remove(struct
of_device *ofdev)
 static struct of_device_id __devinitdata of_platform_serial_table[] = {
 	{ .type = "serial", .compatible = "ns8250",   .data = (void
*)PORT_8250, },
 	{ .type = "serial", .compatible = "ns16450",  .data = (void
*)PORT_16450, },
+	{ .type = "serial", .compatible = "xlnx,xps-uart16550-2.00.b",