diff mbox

coreutils: get the uptime program to work

Message ID 1410381844-14466-1-git-send-email-thomas.petazzoni@free-electrons.com
State Accepted
Commit 652ad4678a3d9172b94b8a06844ccbfd5969c8c5
Headers show

Commit Message

Thomas Petazzoni Sept. 10, 2014, 8:44 p.m. UTC
coreutils configure script needs to know whether /proc/uptime is
available, but this is not possible in a cross-compilation
context. This leads to an uptime program that fails to work on the
target, as it has been compiled without /proc/uptime reading support.

This commit fixes that by telling coreutils at configure time that
/proc/uptime will be available on the target (which seems to be a
reasonable assumption on Linux systems).

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/coreutils/coreutils.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Vicente Olivert Riera Sept. 11, 2014, 9:12 a.m. UTC | #1
Dear ThomasP,

On 09/10/2014 09:44 PM, Thomas Petazzoni wrote:
> coreutils configure script needs to know whether /proc/uptime is
> available, but this is not possible in a cross-compilation
> context. This leads to an uptime program that fails to work on the
> target, as it has been compiled without /proc/uptime reading support.
>
> This commit fixes that by telling coreutils at configure time that
> /proc/uptime will be available on the target (which seems to be a
> reasonable assumption on Linux systems).
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>   package/coreutils/coreutils.mk | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk
> index 07a1347..e6af7e2 100644
> --- a/package/coreutils/coreutils.mk
> +++ b/package/coreutils/coreutils.mk
> @@ -57,6 +57,7 @@ COREUTILS_CONF_ENV = ac_cv_c_restrict=no \
>   		gl_cv_func_working_mkstemp=yes \
>   		gl_cv_func_working_utimes=yes \
>   		gl_getline_needs_run_time_check=no \
> +		gl_cv_have_proc_uptime=yes \
>   		utils_cv_localtime_cache=no \
>   		PERL=missing
>
>

Welcome to Buildroot
(none) login: root
# uptime
  00:00am  up   0:00,  1 user,  load average: 0.46, 0.00, 0.10

It works :)

Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Peter Korsgaard Sept. 13, 2014, 9:54 p.m. UTC | #2
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > coreutils configure script needs to know whether /proc/uptime is
 > available, but this is not possible in a cross-compilation
 > context. This leads to an uptime program that fails to work on the
 > target, as it has been compiled without /proc/uptime reading support.

 > This commit fixes that by telling coreutils at configure time that
 > /proc/uptime will be available on the target (which seems to be a
 > reasonable assumption on Linux systems).

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk
index 07a1347..e6af7e2 100644
--- a/package/coreutils/coreutils.mk
+++ b/package/coreutils/coreutils.mk
@@ -57,6 +57,7 @@  COREUTILS_CONF_ENV = ac_cv_c_restrict=no \
 		gl_cv_func_working_mkstemp=yes \
 		gl_cv_func_working_utimes=yes \
 		gl_getline_needs_run_time_check=no \
+		gl_cv_have_proc_uptime=yes \
 		utils_cv_localtime_cache=no \
 		PERL=missing