Add new Linux 3.16 constants to netinet/udp.h
diff mbox

Message ID Pine.LNX.4.64.1409102027430.21930@digraph.polyomino.org.uk
State New
Headers show

Commit Message

Joseph Myers Sept. 10, 2014, 8:28 p.m. UTC
On Wed, 10 Sep 2014, Florian Weimer wrote:

> On 09/10/2014 07:24 PM, Joseph S. Myers wrote:
> > +#define UDP_NO_CHECK6_TX 101	/* Disable sending checksum for UDP6X.  */
> 
> “UDP6X” appears to be a typo for “UDP6” in the kernel sources, but it should
> actually say “UDP over IPv6” in our version because that's more descriptive.

Here's a patch with the comments revised accordingly.

2014-09-10  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/gnu/netinet/udp.h (UDP_NO_CHECK6_TX): New macro.
	(UDP_NO_CHECK6_RX): Likewise.

Comments

Florian Weimer Sept. 12, 2014, 11:39 a.m. UTC | #1
On 09/10/2014 10:28 PM, Joseph S. Myers wrote:
> On Wed, 10 Sep 2014, Florian Weimer wrote:
>
>> On 09/10/2014 07:24 PM, Joseph S. Myers wrote:
>>> +#define UDP_NO_CHECK6_TX 101	/* Disable sending checksum for UDP6X.  */
>>
>> “UDP6X” appears to be a typo for “UDP6” in the kernel sources, but it should
>> actually say “UDP over IPv6” in our version because that's more descriptive.
>
> Here's a patch with the comments revised accordingly.

Thanks.  Looks good to me.

Patch
diff mbox

diff --git a/sysdeps/gnu/netinet/udp.h b/sysdeps/gnu/netinet/udp.h
index 32159cd..8cc1c60 100644
--- a/sysdeps/gnu/netinet/udp.h
+++ b/sysdeps/gnu/netinet/udp.h
@@ -78,6 +78,10 @@  struct udphdr
 #define UDP_CORK	1	/* Never send partially complete segments.  */
 #define UDP_ENCAP	100	/* Set the socket to accept
 				   encapsulated packets.  */
+#define UDP_NO_CHECK6_TX 101	/* Disable sending checksum for UDP
+				   over IPv6.  */
+#define UDP_NO_CHECK6_RX 102	/* Disable accepting checksum for UDP
+				   over IPv6.  */
 
 /* UDP encapsulation types */
 #define UDP_ENCAP_ESPINUDP_NON_IKE 1	/* draft-ietf-ipsec-nat-t-ike-00/01 */