diff mbox

[1/4] acpi: method: add check for _EVT

Message ID 1410335807-19236-1-git-send-email-alex.hung@canonical.com
State Accepted
Headers show

Commit Message

Alex Hung Sept. 10, 2014, 7:56 a.m. UTC
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/method/method.c | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

Comments

Colin Ian King Sept. 10, 2014, 8:13 a.m. UTC | #1
On 10/09/14 08:56, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 21 +++++++++++++++++++--
>  1 file changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 64e87f1..f92f8a3 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -91,7 +91,7 @@
>   * _EDL  6.3.1		Y
>   * _EJD  6.3.2		Y
>   * _EJx  6.3.3		Y
> - * _EVT  5.6.5.3	n/a
> + * _EVT  5.6.5.3	Y
>   * _FDE  9.9.1		N (floppy controller, ignore)
>   * _FDI  9.9.2		N (floppy controller, ignore)
>   * _FDM  9.9.3		N (floppy controller, ignore)
> @@ -883,6 +883,23 @@ static int method_test_AEI(fwts_framework *fw)
>  		"_AEI", NULL, 0, method_test_buffer_return, NULL);
>  }
>  
> +static int method_test_EVT(fwts_framework *fw)
> +{
> +	ACPI_OBJECT arg[1];
> +	int ret, i;
> +
> +	arg[0].Type = ACPI_TYPE_INTEGER;
> +	for (i = 0; i < 65535; i++) {
> +		arg[0].Integer.Value = i;
> +		ret = method_evaluate_method(fw, METHOD_OPTIONAL,
> +			"_EVT", arg, 1, method_test_NULL_return, NULL);
> +
> +		if (ret != FWTS_OK)
> +			break;
> +	}
> +	return ret;
> +}
> +
>  /*
>   * Section 5.8 System Configuration Objects
>   */
> @@ -4972,7 +4989,7 @@ static fwts_framework_minor_test method_tests[] = {
>  	/* { method_test_Wxx, "Test _Wxx (Wake Event)." }, */
>  
>  	{ method_test_AEI, "Test _AEI." },
> -	/* { method_test_EVT, "Test _EVT (Event Method)." }, */
> +	{ method_test_EVT, "Test _EVT (Event Method)." },
>  
>  	/* Section 5.7 Predefined Objects */
>  	/* { method_test_DLM, "Test _DLM (Device Lock Mutex)." }, */
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Keng-Yu Lin Sept. 11, 2014, 7:32 a.m. UTC | #2
On Wed, Sep 10, 2014 at 3:56 PM, Alex Hung <alex.hung@canonical.com> wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 21 +++++++++++++++++++--
>  1 file changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 64e87f1..f92f8a3 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -91,7 +91,7 @@
>   * _EDL  6.3.1         Y
>   * _EJD  6.3.2         Y
>   * _EJx  6.3.3         Y
> - * _EVT  5.6.5.3       n/a
> + * _EVT  5.6.5.3       Y
>   * _FDE  9.9.1         N (floppy controller, ignore)
>   * _FDI  9.9.2         N (floppy controller, ignore)
>   * _FDM  9.9.3         N (floppy controller, ignore)
> @@ -883,6 +883,23 @@ static int method_test_AEI(fwts_framework *fw)
>                 "_AEI", NULL, 0, method_test_buffer_return, NULL);
>  }
>
> +static int method_test_EVT(fwts_framework *fw)
> +{
> +       ACPI_OBJECT arg[1];
> +       int ret, i;
> +
> +       arg[0].Type = ACPI_TYPE_INTEGER;
> +       for (i = 0; i < 65535; i++) {
> +               arg[0].Integer.Value = i;
> +               ret = method_evaluate_method(fw, METHOD_OPTIONAL,
> +                       "_EVT", arg, 1, method_test_NULL_return, NULL);
> +
> +               if (ret != FWTS_OK)
> +                       break;
> +       }
> +       return ret;
> +}
> +
>  /*
>   * Section 5.8 System Configuration Objects
>   */
> @@ -4972,7 +4989,7 @@ static fwts_framework_minor_test method_tests[] = {
>         /* { method_test_Wxx, "Test _Wxx (Wake Event)." }, */
>
>         { method_test_AEI, "Test _AEI." },
> -       /* { method_test_EVT, "Test _EVT (Event Method)." }, */
> +       { method_test_EVT, "Test _EVT (Event Method)." },
>
>         /* Section 5.7 Predefined Objects */
>         /* { method_test_DLM, "Test _DLM (Device Lock Mutex)." }, */
> --
> 1.9.1
>
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index 64e87f1..f92f8a3 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -91,7 +91,7 @@ 
  * _EDL  6.3.1		Y
  * _EJD  6.3.2		Y
  * _EJx  6.3.3		Y
- * _EVT  5.6.5.3	n/a
+ * _EVT  5.6.5.3	Y
  * _FDE  9.9.1		N (floppy controller, ignore)
  * _FDI  9.9.2		N (floppy controller, ignore)
  * _FDM  9.9.3		N (floppy controller, ignore)
@@ -883,6 +883,23 @@  static int method_test_AEI(fwts_framework *fw)
 		"_AEI", NULL, 0, method_test_buffer_return, NULL);
 }
 
+static int method_test_EVT(fwts_framework *fw)
+{
+	ACPI_OBJECT arg[1];
+	int ret, i;
+
+	arg[0].Type = ACPI_TYPE_INTEGER;
+	for (i = 0; i < 65535; i++) {
+		arg[0].Integer.Value = i;
+		ret = method_evaluate_method(fw, METHOD_OPTIONAL,
+			"_EVT", arg, 1, method_test_NULL_return, NULL);
+
+		if (ret != FWTS_OK)
+			break;
+	}
+	return ret;
+}
+
 /*
  * Section 5.8 System Configuration Objects
  */
@@ -4972,7 +4989,7 @@  static fwts_framework_minor_test method_tests[] = {
 	/* { method_test_Wxx, "Test _Wxx (Wake Event)." }, */
 
 	{ method_test_AEI, "Test _AEI." },
-	/* { method_test_EVT, "Test _EVT (Event Method)." }, */
+	{ method_test_EVT, "Test _EVT (Event Method)." },
 
 	/* Section 5.7 Predefined Objects */
 	/* { method_test_DLM, "Test _DLM (Device Lock Mutex)." }, */