| Message ID | 1410303761-13485-1-git-send-email-jcmvbkbc@gmail.com |
|---|---|
| State | New |
| Headers | show |
On 09/09/2014 04:02 PM, Max Filippov wrote: > movcond has its cond argument first, not last. Fix that in > documentation. > > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> > --- > tcg/README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tcg/README b/tcg/README > index a550ff1..69f3456 100644 > --- a/tcg/README > +++ b/tcg/README > @@ -328,7 +328,7 @@ dest = (t1 cond t2) > > Set DEST to 1 if (T1 cond T2) is true, otherwise set to 0. > > -* movcond_i32/i64 dest, c1, c2, v1, v2, cond > +* movcond_i32/i64 cond, dest, c1, c2, v1, v2 No. The README is supposed to be documenting the *opcode* argument ordering, which really does place cond last. I agree the situation with the helpers using a different ordering is confusing. If we were going to change anything to match, it'd have to be the helpers -- the concept of constant opcode arguments coming last is buried quite deep in TCG. r~
On Tue, Sep 9, 2014 at 4:12 PM, Richard Henderson <rth@twiddle.net> wrote: > On 09/09/2014 04:02 PM, Max Filippov wrote: >> movcond has its cond argument first, not last. Fix that in >> documentation. > No. The README is supposed to be documenting the *opcode* argument ordering, > which really does place cond last. > > I agree the situation with the helpers using a different ordering is confusing. > If we were going to change anything to match, it'd have to be the helpers -- > the concept of constant opcode arguments coming last is buried quite deep in TCG. Maybe put a note about that difference there? Seems like I hit it every time I add something to translate.c.
diff --git a/tcg/README b/tcg/README index a550ff1..69f3456 100644 --- a/tcg/README +++ b/tcg/README @@ -328,7 +328,7 @@ dest = (t1 cond t2) Set DEST to 1 if (T1 cond T2) is true, otherwise set to 0. -* movcond_i32/i64 dest, c1, c2, v1, v2, cond +* movcond_i32/i64 cond, dest, c1, c2, v1, v2 dest = (c1 cond c2 ? v1 : v2)
movcond has its cond argument first, not last. Fix that in documentation. Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> --- tcg/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)