Message ID | 1409931138-25447-1-git-send-email-andriy.shevchenko@linux.intel.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Fri, 2014-09-05 at 18:32 +0300, Andy Shevchenko wrote: > Instead of dereference each byte let's use %*ph specifier in the printk() > calls. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > - Since v1: > - compile tested > - fix a wrong argument list > net/rose/rose_link.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/rose/rose_link.c b/net/rose/rose_link.c > index bc55142..e873d7d 100644 > --- a/net/rose/rose_link.c > +++ b/net/rose/rose_link.c > @@ -160,7 +160,8 @@ void rose_link_rx_restart(struct sk_buff *skb, struct rose_neigh *neigh, unsigne > break; > > case ROSE_DIAGNOSTIC: > - printk(KERN_WARNING "ROSE: received diagnostic #%d - %02X %02X %02X\n", skb->data[3], skb->data[4], skb->data[5], skb->data[6]); > + pr_warn("ROSE: received diagnostic #%d - %3ph\n", skb->data[3], > + skb->data + 4); > break; > > default: This looks better ;) Acked-by: Eric Dumazet <edumazet@google.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Date: Fri, 5 Sep 2014 18:32:18 +0300 > Instead of dereference each byte let's use %*ph specifier in the printk() > calls. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/rose/rose_link.c b/net/rose/rose_link.c index bc55142..e873d7d 100644 --- a/net/rose/rose_link.c +++ b/net/rose/rose_link.c @@ -160,7 +160,8 @@ void rose_link_rx_restart(struct sk_buff *skb, struct rose_neigh *neigh, unsigne break; case ROSE_DIAGNOSTIC: - printk(KERN_WARNING "ROSE: received diagnostic #%d - %02X %02X %02X\n", skb->data[3], skb->data[4], skb->data[5], skb->data[6]); + pr_warn("ROSE: received diagnostic #%d - %3ph\n", skb->data[3], + skb->data + 4); break; default:
Instead of dereference each byte let's use %*ph specifier in the printk() calls. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- - Since v1: - compile tested - fix a wrong argument list net/rose/rose_link.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)