| Message ID | 1409903821-24398-1-git-send-email-sr@denx.de |
|---|---|
| State | Accepted |
| Delegated to: | Scott Wood |
| Headers | show |
Hello Stefan, Am 05.09.2014 09:57, schrieb Stefan Roese: > The ioread16_rep() and iowrite16_rep() implementations are U-Boot specific > and have been introduced with the Linux MTD v3.14 sync. While introducing > these functions, the length for the loop has been miscalculated. The ">> 1" > is already present in the caller. So lets remove it in the function. > > Tested on omap3_ha. > > Signed-off-by: Stefan Roese<sr@denx.de> > Cc: Heiko Schocher<hs@denx.de> > Cc: Tom Rini<trini@ti.com> > Cc: Scott Wood<scottwood@freescale.com> > --- > drivers/mtd/nand/nand_base.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Good catch, thanks! Acked-by: Heiko Schocher <hs@denx.de> bye, Heiko
Hi Scott, Hi Tom, On 05.09.2014 10:06, Heiko Schocher wrote: >> The ioread16_rep() and iowrite16_rep() implementations are U-Boot >> specific >> and have been introduced with the Linux MTD v3.14 sync. While introducing >> these functions, the length for the loop has been miscalculated. The >> ">> 1" >> is already present in the caller. So lets remove it in the function. >> >> Tested on omap3_ha. >> >> Signed-off-by: Stefan Roese<sr@denx.de> >> Cc: Heiko Schocher<hs@denx.de> >> Cc: Tom Rini<trini@ti.com> >> Cc: Scott Wood<scottwood@freescale.com> >> --- >> drivers/mtd/nand/nand_base.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) > > Good catch, thanks! > > Acked-by: Heiko Schocher <hs@denx.de> This patch is also still missing. We really should add it in this upcoming release. Thanks, Stefan
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c index 085b154..c378e2a 100644 --- a/drivers/mtd/nand/nand_base.c +++ b/drivers/mtd/nand/nand_base.c @@ -309,8 +309,7 @@ static void ioread16_rep(void *addr, void *buf, int len) { int i; u16 *p = (u16 *) buf; - len >>= 1; - + for (i = 0; i < len; i++) p[i] = readw(addr); } @@ -319,7 +318,6 @@ static void iowrite16_rep(void *addr, void *buf, int len) { int i; u16 *p = (u16 *) buf; - len >>= 1; for (i = 0; i < len; i++) writew(p[i], addr);
The ioread16_rep() and iowrite16_rep() implementations are U-Boot specific and have been introduced with the Linux MTD v3.14 sync. While introducing these functions, the length for the loop has been miscalculated. The ">> 1" is already present in the caller. So lets remove it in the function. Tested on omap3_ha. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Heiko Schocher <hs@denx.de> Cc: Tom Rini <trini@ti.com> Cc: Scott Wood <scottwood@freescale.com> --- drivers/mtd/nand/nand_base.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)