| Submitter | Tobias Brunner |
|---|---|
| Date | Oct. 10, 2008, 8:16 p.m. |
| Message ID | <48EFB830.6030006@strongswan.org> |
| Download | mbox | patch |
| Permalink | /patch/3861/ |
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
Comments
From: Tobias Brunner <tobias.brunner@strongswan.org> Date: Fri, 10 Oct 2008 22:16:48 +0200 > When deleting an SPD entry using SADB_X_SPDDELETE, c.data.byid is > not initialized to zero in pfkey_spddelete(). Thus, > key_notify_policy() responds with a PF_KEY message of type > SADB_X_SPDDELETE2 instead of SADB_X_SPDDELETE. > > Signed-off-by: Tobias Brunner <tobias.brunner@strongswan.org> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/net/key/af_key.c b/net/key/af_key.c index 362fe31..e55e044 100644 --- a/net/key/af_key.c +++ b/net/key/af_key.c @@ -2341,6 +2341,7 @@ static int pfkey_spddelete(struct sock *sk, struct sk_buff *skb, struct sadb_msg c.seq = hdr->sadb_msg_seq; c.pid = hdr->sadb_msg_pid; + c.data.byid = 0; c.event = XFRM_MSG_DELPOLICY; km_policy_notify(xp, pol->sadb_x_policy_dir-1, &c);
When deleting an SPD entry using SADB_X_SPDDELETE, c.data.byid is not initialized to zero in pfkey_spddelete(). Thus, key_notify_policy() responds with a PF_KEY message of type SADB_X_SPDDELETE2 instead of SADB_X_SPDDELETE. Signed-off-by: Tobias Brunner <tobias.brunner@strongswan.org> --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html