Patchwork [3/9] default devices: parallel port

login
register
mail settings
Submitter Gerd Hoffmann
Date Nov. 17, 2009, 9:38 a.m.
Message ID <1258450699-24445-4-git-send-email-kraxel@redhat.com>
Download mbox | patch
Permalink /patch/38598/
State New
Headers show

Comments

Gerd Hoffmann - Nov. 17, 2009, 9:38 a.m.
Switch over parallel ports to the new default device system.

Disable default parallel port for both '-parallel' and '-device
isa-parallel' cases.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 vl.c |   68 +++++++++++++++++++++++++++++++++---------------------------------
 1 files changed, 34 insertions(+), 34 deletions(-)
Markus Armbruster - Nov. 20, 2009, 4:52 p.m.
Gerd Hoffmann <kraxel@redhat.com> writes:

> Switch over parallel ports to the new default device system.
>
> Disable default parallel port for both '-parallel' and '-device
> isa-parallel' cases.

This feels a bit terse to me.  What about a suitably edited copy of
PATCH 2/9's message?

>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  vl.c |   68 +++++++++++++++++++++++++++++++++---------------------------------
>  1 files changed, 34 insertions(+), 34 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 967d499..739c3a7 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -271,12 +271,14 @@ static QEMUBootSetHandler *boot_set_handler;
>  static void *boot_set_opaque;
>  
>  static int default_serial = 1;
> +static int default_parallel = 1;
>  
>  static struct {
>      const char *driver;
>      int *flag;
>  } default_list[] = {
> -    { .driver = "isa-serial", .flag = &default_serial }
> +    { .driver = "isa-serial",     .flag = &default_serial    },
> +    { .driver = "isa-parallel",   .flag = &default_parallel  },
>  };
>  
>  static int default_driver_check(QemuOpts *opts, void *opaque)
> @@ -4568,6 +4570,7 @@ struct device_config {
>          DEV_USB,       /* -usbdevice   */
>          DEV_BT,        /* -bt          */
>          DEV_SERIAL,    /* -serial      */
> +        DEV_PARALLEL,  /* -parallel    */
>      } type;
>      const char *cmdline;
>      QTAILQ_ENTRY(device_config) next;
> @@ -4643,6 +4646,28 @@ static int serial_parse(const char *devname)
>      return 0;
>  }
>  
> +static int parallel_parse(const char *devname)
> +{
> +    static int index = 0;
> +    char label[32];
> +
> +    if (strcmp(devname, "none") == 0)
> +        return 0;
> +    snprintf(label, sizeof(label), "parallel%d", index);
> +    parallel_hds[index] = qemu_chr_open(label, devname, NULL);

Like for serial_parse(): don't you have to catch index >=
MAX_PARALLEL_PORTS here?

> +    if (!parallel_hds[index]) {
> +        fprintf(stderr, "qemu: could not open parallel device '%s': %s\n",
> +                devname, strerror(errno));
> +        return -1;
> +    }
> +    if (strstart(devname, "vc", 0)) {
> +        snprintf(label, sizeof(label), "parallel%d console\r\n", index);
> +        parallel_hds[index]->greeting = qemu_strdup(label);
> +    }
> +    index++;
> +    return 0;
> +}
> +
>  int main(int argc, char **argv, char **envp)
>  {
>      const char *gdbstub_dev = NULL;
> @@ -4661,8 +4686,6 @@ int main(int argc, char **argv, char **envp)
[...]

Patch

diff --git a/vl.c b/vl.c
index 967d499..739c3a7 100644
--- a/vl.c
+++ b/vl.c
@@ -271,12 +271,14 @@  static QEMUBootSetHandler *boot_set_handler;
 static void *boot_set_opaque;
 
 static int default_serial = 1;
+static int default_parallel = 1;
 
 static struct {
     const char *driver;
     int *flag;
 } default_list[] = {
-    { .driver = "isa-serial", .flag = &default_serial }
+    { .driver = "isa-serial",     .flag = &default_serial    },
+    { .driver = "isa-parallel",   .flag = &default_parallel  },
 };
 
 static int default_driver_check(QemuOpts *opts, void *opaque)
@@ -4568,6 +4570,7 @@  struct device_config {
         DEV_USB,       /* -usbdevice   */
         DEV_BT,        /* -bt          */
         DEV_SERIAL,    /* -serial      */
+        DEV_PARALLEL,  /* -parallel    */
     } type;
     const char *cmdline;
     QTAILQ_ENTRY(device_config) next;
@@ -4643,6 +4646,28 @@  static int serial_parse(const char *devname)
     return 0;
 }
 
+static int parallel_parse(const char *devname)
+{
+    static int index = 0;
+    char label[32];
+
+    if (strcmp(devname, "none") == 0)
+        return 0;
+    snprintf(label, sizeof(label), "parallel%d", index);
+    parallel_hds[index] = qemu_chr_open(label, devname, NULL);
+    if (!parallel_hds[index]) {
+        fprintf(stderr, "qemu: could not open parallel device '%s': %s\n",
+                devname, strerror(errno));
+        return -1;
+    }
+    if (strstart(devname, "vc", 0)) {
+        snprintf(label, sizeof(label), "parallel%d console\r\n", index);
+        parallel_hds[index]->greeting = qemu_strdup(label);
+    }
+    index++;
+    return 0;
+}
+
 int main(int argc, char **argv, char **envp)
 {
     const char *gdbstub_dev = NULL;
@@ -4661,8 +4686,6 @@  int main(int argc, char **argv, char **envp)
     CharDriverState *monitor_hds[MAX_MONITOR_DEVICES];
     const char *monitor_devices[MAX_MONITOR_DEVICES];
     int monitor_device_index;
-    const char *parallel_devices[MAX_PARALLEL_PORTS];
-    int parallel_device_index;
     const char *virtio_consoles[MAX_VIRTIO_CONSOLES];
     int virtio_console_index;
     const char *loadvm = NULL;
@@ -4730,11 +4753,6 @@  int main(int argc, char **argv, char **envp)
     cyls = heads = secs = 0;
     translation = BIOS_ATA_TRANSLATION_AUTO;
 
-    parallel_devices[0] = "vc:80Cx24C";
-    for(i = 1; i < MAX_PARALLEL_PORTS; i++)
-        parallel_devices[i] = NULL;
-    parallel_device_index = 0;
-
     for(i = 0; i < MAX_VIRTIO_CONSOLES; i++)
         virtio_consoles[i] = NULL;
     virtio_console_index = 0;
@@ -5204,12 +5222,8 @@  int main(int argc, char **argv, char **envp)
                 virtio_console_index++;
                 break;
             case QEMU_OPTION_parallel:
-                if (parallel_device_index >= MAX_PARALLEL_PORTS) {
-                    fprintf(stderr, "qemu: too many parallel ports\n");
-                    exit(1);
-                }
-                parallel_devices[parallel_device_index] = optarg;
-                parallel_device_index++;
+                add_device_config(DEV_PARALLEL, optarg);
+                default_parallel = 0;
                 break;
 	    case QEMU_OPTION_loadvm:
 		loadvm = optarg;
@@ -5485,14 +5499,16 @@  int main(int argc, char **argv, char **envp)
     if (display_type == DT_NOGRAPHIC) {
         if (default_serial)
             add_device_config(DEV_SERIAL, "stdio");
-       if (parallel_device_index == 0)
-           parallel_devices[0] = "null";
+        if (default_parallel)
+            add_device_config(DEV_PARALLEL, "null");
        if (strncmp(monitor_devices[0], "vc", 2) == 0) {
            monitor_devices[0] = "stdio";
        }
     } else {
         if (default_serial)
             add_device_config(DEV_SERIAL, "vc:80Cx24C");
+        if (default_parallel)
+            add_device_config(DEV_PARALLEL, "vc:80Cx24C");
     }
 
 #ifndef _WIN32
@@ -5699,24 +5715,8 @@  int main(int argc, char **argv, char **envp)
 
     if (foreach_device_config(DEV_SERIAL, serial_parse) < 0)
         exit(1);
-
-    for(i = 0; i < MAX_PARALLEL_PORTS; i++) {
-        const char *devname = parallel_devices[i];
-        if (devname && strcmp(devname, "none")) {
-            char label[32];
-            snprintf(label, sizeof(label), "parallel%d", i);
-            parallel_hds[i] = qemu_chr_open(label, devname, NULL);
-            if (!parallel_hds[i]) {
-                fprintf(stderr, "qemu: could not open parallel device '%s': %s\n",
-                        devname, strerror(errno));
-                exit(1);
-            }
-            if (strstart(devname, "vc", 0)) {
-                snprintf(label, sizeof(label), "parallel%d console\r\n", i);
-                parallel_hds[i]->greeting = qemu_strdup(label);
-            }
-        }
-    }
+    if (foreach_device_config(DEV_PARALLEL, parallel_parse) < 0)
+        exit(1);
 
     for(i = 0; i < MAX_VIRTIO_CONSOLES; i++) {
         const char *devname = virtio_consoles[i];