| Message ID | 1409804929-30914-1-git-send-email-yidi.lin@canonical.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Sep 04, 2014 at 12:28:49PM +0800, Edward Lin wrote: > BugLink: http://bugs.launchpad.net/bugs/1354313 > BugLink: http://bugs.launchpad.net/bugs/1354253 > > Signed-off-by: Edward Lin <yidi.lin@canonical.com> > --- > drivers/acpi/video.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c > index ffdd2c6..e858463 100644 > --- a/drivers/acpi/video.c > +++ b/drivers/acpi/video.c > @@ -516,6 +516,22 @@ static struct dmi_system_id video_dmi_table[] __initdata = { > }, > { > .callback = video_set_use_native_backlight, > + .ident = "Dell Inspiron 5721", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5721"), > + }, > + }, > + { > + .callback = video_set_use_native_backlight, > + .ident = "Dell Inspiron 3521", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 3521"), > + }, > + }, > + { > + .callback = video_set_use_native_backlight, > .ident = "Acer Aspire 5733Z", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Acer"), These look safe and self contained. I assume these are on their way upstream? Acked-by: Andy Whitcroft <apw@canonical.com> -apw
On Thu, Sep 04, 2014 at 11:30:01AM +0100, Andy Whitcroft wrote: > On Thu, Sep 04, 2014 at 12:28:49PM +0800, Edward Lin wrote: > > BugLink: http://bugs.launchpad.net/bugs/1354313 > > BugLink: http://bugs.launchpad.net/bugs/1354253 > > > > Signed-off-by: Edward Lin <yidi.lin@canonical.com> > > --- > > drivers/acpi/video.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c > > index ffdd2c6..e858463 100644 > > --- a/drivers/acpi/video.c > > +++ b/drivers/acpi/video.c > > @@ -516,6 +516,22 @@ static struct dmi_system_id video_dmi_table[] __initdata = { > > }, > > { > > .callback = video_set_use_native_backlight, > > + .ident = "Dell Inspiron 5721", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > > + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5721"), > > + }, > > + }, > > + { > > + .callback = video_set_use_native_backlight, > > + .ident = "Dell Inspiron 3521", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > > + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 3521"), > > + }, > > + }, > > + { > > + .callback = video_set_use_native_backlight, > > .ident = "Acer Aspire 5733Z", > > .matches = { > > DMI_MATCH(DMI_SYS_VENDOR, "Acer"), > > These look safe and self contained. I assume these are on their way > upstream? I agree. Acked-by: Seth Forshee <seth.forshee@canonical.com> Probably not applicable for upstream though. Upstream switched to make video.use_native_backlight default to 1, and now seems to be going through the process of quirking machines which need it to be 0 (https://www.mail-archive.com/stable@vger.kernel.org/msg91591.html).
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index ffdd2c6..e858463 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -516,6 +516,22 @@ static struct dmi_system_id video_dmi_table[] __initdata = { }, { .callback = video_set_use_native_backlight, + .ident = "Dell Inspiron 5721", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5721"), + }, + }, + { + .callback = video_set_use_native_backlight, + .ident = "Dell Inspiron 3521", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 3521"), + }, + }, + { + .callback = video_set_use_native_backlight, .ident = "Acer Aspire 5733Z", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
BugLink: http://bugs.launchpad.net/bugs/1354313 BugLink: http://bugs.launchpad.net/bugs/1354253 Signed-off-by: Edward Lin <yidi.lin@canonical.com> --- drivers/acpi/video.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)