diff mbox

[U-Boot,v2,4/4] kconfig: fix a bug of "make config"

Message ID 1409776894-30441-5-git-send-email-yamada.m@jp.panasonic.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Masahiro Yamada Sept. 3, 2014, 8:41 p.m. UTC 
Since 3ff291f371fa9858426774f3732924bacb61ed1c
(kconfig: convert Kconfig helper script into a shell script),
"make config" is not working because of a missing '$' before '(Q)'.

Besides, "make config" should be invoked via scripts/multiconfig.sh
to avoid a warning message:
Kconfig:11:warning: environment variable KCONFIG_OBJDIR undefined

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

Changes in v2:
  - Newly added

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Sept. 3, 2014, 11:51 p.m. UTC | #1 
On 3 September 2014 14:41, Masahiro Yamada <yamada.m@jp.panasonic.com> wrote:
> Since 3ff291f371fa9858426774f3732924bacb61ed1c
> (kconfig: convert Kconfig helper script into a shell script),
> "make config" is not working because of a missing '$' before '(Q)'.
>
> Besides, "make config" should be invoked via scripts/multiconfig.sh
> to avoid a warning message:
> Kconfig:11:warning: environment variable KCONFIG_OBJDIR undefined
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Acked-by: Simon Glass <sjg@chromium.org>
Tom Rini Sept. 17, 2014, 12:45 a.m. UTC | #2 
On Thu, Sep 04, 2014 at 05:41:34AM +0900, Masahiro Yamada wrote:

> Since 3ff291f371fa9858426774f3732924bacb61ed1c
> (kconfig: convert Kconfig helper script into a shell script),
> "make config" is not working because of a missing '$' before '(Q)'.
> 
> Besides, "make config" should be invoked via scripts/multiconfig.sh
> to avoid a warning message:
> Kconfig:11:warning: environment variable KCONFIG_OBJDIR undefined
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/Makefile b/Makefile
index fdda3ec..fe7d98f 100644
--- a/Makefile
+++ b/Makefile
@@ -458,7 +458,7 @@  KBUILD_DEFCONFIG := sandbox_defconfig
 export KBUILD_DEFCONFIG KBUILD_KCONFIG
 
 config: scripts_basic outputmakefile FORCE
-	(Q)$(MAKE) $(build)=scripts/kconfig $@
+	+$(Q)$(CONFIG_SHELL) $(srctree)/scripts/multiconfig.sh $@
 
 %config: scripts_basic outputmakefile FORCE
 	+$(Q)$(CONFIG_SHELL) $(srctree)/scripts/multiconfig.sh $@