diff mbox

[1/3] trace: Only link generated-tracers.o with "simple" backend

Message ID 1409715896-14322-2-git-send-email-famz@redhat.com
State New
Headers show

Commit Message

Fam Zheng Sept. 3, 2014, 3:44 a.m. UTC
In any other cases the object file is effectively empty, which is
disliked by ranlib and nm on Mac OS X.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 trace/Makefile.objs | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Stefan Hajnoczi Sept. 5, 2014, 9:04 a.m. UTC | #1
On Wed, Sep 03, 2014 at 11:44:54AM +0800, Fam Zheng wrote:
> In any other cases the object file is effectively empty, which is
> disliked by ranlib and nm on Mac OS X.
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  trace/Makefile.objs | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

If another trace backend uses generate_c() there will be a link error so
they'll figure out they need to add it in the makefile.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
diff mbox

Patch

diff --git a/trace/Makefile.objs b/trace/Makefile.objs
index 387f191..46de95c 100644
--- a/trace/Makefile.objs
+++ b/trace/Makefile.objs
@@ -140,8 +140,7 @@  $(obj)/generated-tcg-tracers.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/
 ######################################################################
 # Backend code
 
-util-obj-$(CONFIG_TRACE_SIMPLE) += simple.o
+util-obj-$(CONFIG_TRACE_SIMPLE) += simple.o generated-tracers.o
 util-obj-$(CONFIG_TRACE_FTRACE) += ftrace.o
 util-obj-$(CONFIG_TRACE_UST) += generated-ust.o
 util-obj-y += control.o
-util-obj-y += generated-tracers.o