| Message ID | 2c7735c0247a4c83a3c2.1409649945@localhost |
|---|---|
| State | Accepted |
| Commit | 53223cbb4e775ce88c036ddbfcca260e23c5739e |
| Headers | show |
Thomas, All, On 2014-09-02 11:25 +0200, Thomas De Schampheleire spake thusly: > # HG changeset patch > # User Thomas De Schampheleire <thomas.de_schampheleire@alcatel-lucent.com> > # Date 1407153076 -7200 > # Mon Aug 04 13:51:16 2014 +0200 > # Node ID 2c7735c0247a4c83a3c2ea1d58e74be613465255 > # Parent 6af0c3866b64670bb6d62302b64f3164b1f70fb6 > check-kernel-headers: mktemp --tmpdir not available on RedHat 5 > > mktemp --tmpdir is not available on older Redhat 5 machines. The alternative > that has the same behavior is 'mktemp -t'. > > Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > support/scripts/check-kernel-headers.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/support/scripts/check-kernel-headers.sh b/support/scripts/check-kernel-headers.sh > --- a/support/scripts/check-kernel-headers.sh > +++ b/support/scripts/check-kernel-headers.sh > @@ -8,7 +8,7 @@ > HDR_V="${HDR_VER#*.}" > HDR_m="${HDR_V%%.*}" > > -EXEC="$(mktemp --tmpdir check-headers.XXXXXX)" > +EXEC="$(mktemp -t check-headers.XXXXXX)" > > # We do not want to account for the patch-level, since headers are > # not supposed to change for different patchlevels, so we mask it out. > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes: > # HG changeset patch > # User Thomas De Schampheleire <thomas.de_schampheleire@alcatel-lucent.com> > # Date 1407153076 -7200 > # Mon Aug 04 13:51:16 2014 +0200 > # Node ID 2c7735c0247a4c83a3c2ea1d58e74be613465255 > # Parent 6af0c3866b64670bb6d62302b64f3164b1f70fb6 Is all of this hg noise needed? Your patches didn't used to contain this. > check-kernel-headers: mktemp --tmpdir not available on RedHat 5 > mktemp --tmpdir is not available on older Redhat 5 machines. The alternative > that has the same behavior is 'mktemp -t'. Redhat Linux 5.0, that was one of the very first Linux distributions I ever used - It's been a while ;) I guess you mean RHEL 5, so I've adjusted the commit message and committed, thanks.
Peter Korsgaard <jacmet@uclibc.org> schreef: >>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes: > > > # HG changeset patch > > # User Thomas De Schampheleire <thomas.de_schampheleire@alcatel-lucent.com> > > # Date 1407153076 -7200 > > # Mon Aug 04 13:51:16 2014 +0200 > > # Node ID 2c7735c0247a4c83a3c2ea1d58e74be613465255 > > # Parent 6af0c3866b64670bb6d62302b64f3164b1f70fb6 > >Is all of this hg noise needed? Your patches didn't used to contain >this. Oi sorry, I have forgotten a switch to turn this off here. > > > check-kernel-headers: mktemp --tmpdir not available on RedHat 5 > > > mktemp --tmpdir is not available on older Redhat 5 machines. The alternative > > that has the same behavior is 'mktemp -t'. > >Redhat Linux 5.0, that was one of the very first Linux distributions I >ever used - It's been a while ;) > >I guess you mean RHEL 5, so I've adjusted the commit message and >committed, thanks. Thanks, I do indeed mean RHEL5, wasn't aware that there was a difference. Best regards, Thomas
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes: Hi, >> Redhat Linux 5.0, that was one of the very first Linux distributions I >> ever used - It's been a while ;) >> >> I guess you mean RHEL 5, so I've adjusted the commit message and >> committed, thanks. > Thanks, I do indeed mean RHEL5, wasn't aware that there was a difference. https://en.wikipedia.org/wiki/Red_Hat_Linux
diff --git a/support/scripts/check-kernel-headers.sh b/support/scripts/check-kernel-headers.sh --- a/support/scripts/check-kernel-headers.sh +++ b/support/scripts/check-kernel-headers.sh @@ -8,7 +8,7 @@ HDR_V="${HDR_VER#*.}" HDR_m="${HDR_V%%.*}" -EXEC="$(mktemp --tmpdir check-headers.XXXXXX)" +EXEC="$(mktemp -t check-headers.XXXXXX)" # We do not want to account for the patch-level, since headers are # not supposed to change for different patchlevels, so we mask it out.
# HG changeset patch # User Thomas De Schampheleire <thomas.de_schampheleire@alcatel-lucent.com> # Date 1407153076 -7200 # Mon Aug 04 13:51:16 2014 +0200 # Node ID 2c7735c0247a4c83a3c2ea1d58e74be613465255 # Parent 6af0c3866b64670bb6d62302b64f3164b1f70fb6 check-kernel-headers: mktemp --tmpdir not available on RedHat 5 mktemp --tmpdir is not available on older Redhat 5 machines. The alternative that has the same behavior is 'mktemp -t'. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> --- support/scripts/check-kernel-headers.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)