From patchwork Sat Aug 30 15:40:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John David Anglin X-Patchwork-Id: 384479 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A335B140085 for ; Sun, 31 Aug 2014 01:40:30 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:from:to:content-type:subject:mime-version:date; q= dns; s=default; b=MT5Ou0iM2AW7IBScUgnziaRJUVdXEOst3MB3vJZqQOU6vI 7rwcus012RoutQD5WTXEKoYWsp0zXak9xTZ6ZTNvWPUZ9e7N4lq4Antw6Uj2zhQC nFJf3g4mC6yRWxvaZq+pbvaa0/2Bhe02fNb5kYKw1OIQ0aluVXARycZE9Ckng= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:from:to:content-type:subject:mime-version:date; s= default; bh=t2Fq8e8e4y64r+dkCkpdTrDc2DU=; b=PISWH54hbj7tSLcoAsLm jg3s5FwizlUt8FdHjbj2f0c0zlhcYa0m8oL9tVpeEqDGL9HDiqzIlvltJvlB/lzu F4P/PvjMzxCe8rZHgxxl1mrXKtYZnVfWrq7PMF5Bik2N7GgTiNhgQTNckVp77Q1v hjC8FZ+zcELAbqS/30WLt3Q= Received: (qmail 25073 invoked by alias); 30 Aug 2014 15:40:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 25061 invoked by uid 89); 30 Aug 2014 15:40:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: BLU004-OMC3S35.hotmail.com Received: from blu004-omc3s35.hotmail.com (HELO BLU004-OMC3S35.hotmail.com) (65.55.116.110) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA256 encrypted) ESMTPS; Sat, 30 Aug 2014 15:40:21 +0000 Received: from BLU436-SMTP218 ([65.55.116.74]) by BLU004-OMC3S35.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.22712); Sat, 30 Aug 2014 08:40:19 -0700 X-TMN: [MW3BQYs4Q17lD7M81TyqiCYACnqKwA8M] Message-ID: Received: from [192.168.2.16] ([70.26.30.52]) by smtphm.sympatico.ca over TLS secured channel with Microsoft SMTPSVC(8.0.9200.16384); Sat, 30 Aug 2014 08:40:18 -0700 From: John David Anglin To: GCC Patches Subject: [committed] Don't request function descriptors when generating fast indirect calls on hppa MIME-Version: 1.0 (Apple Message framework v936) Date: Sat, 30 Aug 2014 11:40:02 -0400 The attached change fixes a rather old regression. The code that is generated with fast indirect calls assumes that a function pointer points directly at the function being called, not a procedure descriptor. Tested on hppa-unknown-linux-gnu and hppa2.0w-hp-hpux11.11. Committed to trunk, 4.9 and 4.8. Dave --- John David Anglin dave.anglin@bell.net 2014-08-30 John David Anglin * config/pa/pa.c (pa_assemble_integer): Don't add PLABEL relocation prefix to function labels when generating fast indirect calls. Index: config/pa/pa.c =================================================================== --- config/pa/pa.c (revision 214400) +++ config/pa/pa.c (working copy) @@ -3217,7 +3217,12 @@ && aligned_p && function_label_operand (x, VOIDmode)) { - fputs (size == 8? "\t.dword\tP%" : "\t.word\tP%", asm_out_file); + fputs (size == 8? "\t.dword\t" : "\t.word\t", asm_out_file); + + /* We don't want an OPD when generating fast indirect calls. */ + if (!TARGET_FAST_INDIRECT_CALLS) + fputs ("P%", asm_out_file); + output_addr_const (asm_out_file, x); fputc ('\n', asm_out_file); return true;