| Message ID | 1409400360-31612-1-git-send-email-vadim4j@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
On 30.08.2014 14:06, Vadim Kochan wrote: > The real checking is performed later in iplink_modify(..) func which > checks device existence if NLM_F_CREATE flag is set. > > Also it fixes the case when impossible to add veth link which was > caused by 9a02651a87 (ip: check for missing dev arg when doing VF rate) > because these devices are not exist yet. > > Signed-off-by: Vadim Kochan <vadim4j@gmail.com> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net> This also fixes this issue from Mehdi Abaakouk here: http://marc.info/?l=linux-netdev&m=140912053421637 And the stuff I needed to change here: https://gitorious.org/linux-can/can-tests/commit/578d07b0a13e0c171801cde8c048ac657373491e Thanks for figuring out the detailed problem Vadim! Regards, Oliver > --- > ip/iplink.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/ip/iplink.c b/ip/iplink.c > index 1a907d9..ea06871 100644 > --- a/ip/iplink.c > +++ b/ip/iplink.c > @@ -593,8 +593,6 @@ int iplink_parse(int argc, char **argv, struct iplink_req *req, > duparg2("dev", *argv); > *dev = *argv; > dev_index = ll_name_to_index(*dev); > - if (dev_index == 0) > - invarg("Unknown device", *argv); > } > argc--; argv++; > } > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/ip/iplink.c b/ip/iplink.c index 1a907d9..ea06871 100644 --- a/ip/iplink.c +++ b/ip/iplink.c @@ -593,8 +593,6 @@ int iplink_parse(int argc, char **argv, struct iplink_req *req, duparg2("dev", *argv); *dev = *argv; dev_index = ll_name_to_index(*dev); - if (dev_index == 0) - invarg("Unknown device", *argv); } argc--; argv++; }
The real checking is performed later in iplink_modify(..) func which checks device existence if NLM_F_CREATE flag is set. Also it fixes the case when impossible to add veth link which was caused by 9a02651a87 (ip: check for missing dev arg when doing VF rate) because these devices are not exist yet. Signed-off-by: Vadim Kochan <vadim4j@gmail.com> --- ip/iplink.c | 2 -- 1 file changed, 2 deletions(-)