Patchwork libata: prepare for removal of experimental tag on PATA drivers

login
register
mail settings
Submitter Bartlomiej Zolnierkiewicz
Date Nov. 14, 2009, 2:37 p.m.
Message ID <200911141537.19068.bzolnier@gmail.com>
Download mbox | patch
Permalink /patch/38436/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Bartlomiej Zolnierkiewicz - Nov. 14, 2009, 2:37 p.m.
Push experimental tags to host drivers that still need it so we can
remove the "global" experimental tag for PATA drivers.

I hear that some issues are being worked on but the patch reflects
the current situation and we can trivially update status of affected
host drivers after new fixes are merged.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ata/Kconfig |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alan Cox - Nov. 14, 2009, 3:23 p.m.
On Sat, 14 Nov 2009 15:37:19 +0100
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:

> Push experimental tags to host drivers that still need it so we can
> remove the "global" experimental tag for PATA drivers.
> 
> I hear that some issues are being worked on but the patch reflects
> the current situation and we can trivially update status of affected
> host drivers after new fixes are merged.
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

NAK

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Robert Hancock - Nov. 14, 2009, 4:01 p.m.
On 11/14/2009 08:37 AM, Bartlomiej Zolnierkiewicz wrote:
> Push experimental tags to host drivers that still need it so we can
> remove the "global" experimental tag for PATA drivers.
>
> I hear that some issues are being worked on but the patch reflects
> the current situation and we can trivially update status of affected
> host drivers after new fixes are merged.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>

I don't think that the problems you've mentioned fit the definition of 
the EXPERIMENTAL tag - it means that the driver isn't likely suitable 
for general use. Given that those drivers are probably used by 
significant numbers of people successfully in various distributions I 
don't think this is likely to be the case. There may be bugs but 
non-experimental does not imply bug free.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bartlomiej Zolnierkiewicz - Nov. 14, 2009, 4:53 p.m.
On Saturday 14 November 2009 17:01:08 Robert Hancock wrote:
> On 11/14/2009 08:37 AM, Bartlomiej Zolnierkiewicz wrote:
> > Push experimental tags to host drivers that still need it so we can
> > remove the "global" experimental tag for PATA drivers.
> >
> > I hear that some issues are being worked on but the patch reflects
> > the current situation and we can trivially update status of affected
> > host drivers after new fixes are merged.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> 
> I don't think that the problems you've mentioned fit the definition of 
> the EXPERIMENTAL tag - it means that the driver isn't likely suitable 

I guess you've read bugzillas so if you still think that EXPERIMENTAL
is not justified at least for some drivers than we really have nothing
to talk about anymore..

> for general use. Given that those drivers are probably used by 
> significant numbers of people successfully in various distributions I 
> don't think this is likely to be the case. There may be bugs but 
> non-experimental does not imply bug free.

Hardly a technical argument.

You know that staging drivers are successfully used by
"significant numbers of people successfully in various distributions"?

:)

zbr explained the problem with the kernel development process with more
class than I would ever be able to so I will just save everybody's time..
Alan Cox - Nov. 14, 2009, 5:03 p.m.
> I guess you've read bugzillas so if you still think that EXPERIMENTAL
> is not justified at least for some drivers than we really have nothing
> to talk about anymore..

What a relief

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

Index: b/drivers/ata/Kconfig
===================================================================
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -230,8 +230,8 @@  config PATA_ACPI
 	  otherwise unsupported hardware.
 
 config PATA_ALI
-	tristate "ALi PATA support"
-	depends on PCI
+	tristate "ALi PATA support (Experimental)"
+	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the ALi ATA interfaces
 	  found on the many ALi chipsets.
@@ -293,8 +293,8 @@  config PATA_CMD640_PCI
 	  If unsure, say N.
 
 config PATA_CMD64X
-	tristate "CMD64x PATA support"
-	depends on PCI
+	tristate "CMD64x PATA support (Experimental)"
+	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the CMD64x series chips
 	  except for the CMD640.
@@ -574,8 +574,8 @@  config PATA_PCMCIA
 	  If unsure, say N.
 
 config PATA_PDC_OLD
-	tristate "Older Promise PATA controller support"
-	depends on PCI
+	tristate "Older Promise PATA controller support (Experimental)"
+	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for the Promise 20246, 20262, 20263,
 	  20265 and 20267 adapters.
@@ -660,8 +660,8 @@  config PATA_SIL680
 	  If unsure, say N.
 
 config PATA_SIS
-	tristate "SiS PATA support"
-	depends on PCI
+	tristate "SiS PATA support (Experimental)"
+	depends on PCI && EXPERIMENTAL
 	help
 	  This option enables support for SiS PATA controllers