diff mbox

acpi: method: fix _STR's output should be buffer, not string (LP: #1362503)

Message ID 1409217415-16574-1-git-send-email-alex.hung@canonical.com
State Accepted
Headers show

Commit Message

Alex Hung Aug. 28, 2014, 9:16 a.m. UTC 
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/method/method.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Colin Ian King Aug. 28, 2014, 9:24 a.m. UTC | #1 
On 28/08/14 10:16, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 48d3203..73dcf4f 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -1038,7 +1038,7 @@ static int method_test_HRV(fwts_framework *fw)
>  static int method_test_STR(fwts_framework *fw)
>  {
>  	return method_evaluate_method(fw, METHOD_OPTIONAL,
> -		"_STR", NULL, 0, method_test_string_return, NULL);
> +		"_STR", NULL, 0, method_test_buffer_return, NULL);
>  }
>  
>  static void method_test_PLD_return(
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Keng-Yu Lin Aug. 28, 2014, 2:39 p.m. UTC | #2 
On Thu, Aug 28, 2014 at 5:16 PM, Alex Hung <alex.hung@canonical.com> wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index 48d3203..73dcf4f 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -1038,7 +1038,7 @@ static int method_test_HRV(fwts_framework *fw)
>  static int method_test_STR(fwts_framework *fw)
>  {
>         return method_evaluate_method(fw, METHOD_OPTIONAL,
> -               "_STR", NULL, 0, method_test_string_return, NULL);
> +               "_STR", NULL, 0, method_test_buffer_return, NULL);
>  }
>
>  static void method_test_PLD_return(
> --
> 1.9.1
>
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index 48d3203..73dcf4f 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -1038,7 +1038,7 @@  static int method_test_HRV(fwts_framework *fw)
 static int method_test_STR(fwts_framework *fw)
 {
 	return method_evaluate_method(fw, METHOD_OPTIONAL,
-		"_STR", NULL, 0, method_test_string_return, NULL);
+		"_STR", NULL, 0, method_test_buffer_return, NULL);
 }
 
 static void method_test_PLD_return(