[15/33] l1sap: additional comments explaining l1sap changes in l1_if.c
diff mbox

Message ID 1409176492-13269-16-git-send-email-laforge@gnumonks.org
State Superseded
Headers show

Commit Message

Harald Welte Aug. 27, 2014, 9:54 p.m. UTC
---
 src/osmo-bts-sysmo/l1_if.c | 4 ++++
 1 file changed, 4 insertions(+)

Patch
diff mbox

diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index d4861e2..03e8a56 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -599,6 +599,7 @@  static uint8_t chan_nr_by_sapi(enum gsm_phys_chan_config pchan,
 		return 0;
 	}
 
+	/* not reached due to default case above */
 	return (cbits << 3) | u8Tn;
 }
 
@@ -1029,10 +1030,13 @@  static int handle_ph_data_ind(struct femtol1_hdl *fl1, GsmL1_PhDataInd_t *data_i
 	}
 
 	if (!chan_nr) {
+		/* message was handled by old code, not by L1SAP */
 		msgb_free(l1p_msg);
 		return rc;
 	}
 
+	/* if we proceed to this point, the message has to be handled via L1SAP */
+
 	/* get data pointer and length */
 	data = data_ind->msgUnitParam.u8Buffer;
 	len = data_ind->msgUnitParam.u8Size;