Patchwork Only configure libstdc++-v3/python dir for hosted builds

login
register
mail settings
Submitter Jonathan Wakely
Date Aug. 27, 2014, 5:50 p.m.
Message ID <20140827175008.GG22778@redhat.com>
Download mbox | patch
Permalink /patch/383531/
State New
Headers show

Comments

Jonathan Wakely - Aug. 27, 2014, 5:50 p.m.
Currently a freestanding build installs the Python GDB hooks as
${libdir}/libstdc*-gdb.py (with a literal * character in the filename)
because there is no libstdc++.so library file and the wildcard doesn't
get expanded (see the install-data-local target in the
libstdc++-v3/python/Makefile.am file).

I don't see any reason to install any Python files for a freestanding
build, the pretty printers and type printers are only useful for types
defined in the hosted library, so this just disables the entire
directory.

Is there any reason not to do this?

Patch

commit e8c1f4879beeeda8625467a4fdaf84b34d243471
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Aug 27 18:39:00 2014 +0100

    	* Makefile.am (SUBDIRS): Move python to hosted_source.
    	* Makefile.in: Regenerate.

diff --git a/libstdc++-v3/Makefile.am b/libstdc++-v3/Makefile.am
index b602202..42cff3e 100644
--- a/libstdc++-v3/Makefile.am
+++ b/libstdc++-v3/Makefile.am
@@ -23,12 +23,12 @@ 
 include $(top_srcdir)/fragment.am
 
 if GLIBCXX_HOSTED
-  hosted_source = src doc po testsuite
+## Note that python must come after src.
+  hosted_source = src doc po testsuite python
 endif
 
 ## Keep this list sync'd with acinclude.m4:GLIBCXX_CONFIGURE.
-## Note that python must come after src.
-SUBDIRS = include libsupc++ $(hosted_source) python
+SUBDIRS = include libsupc++ $(hosted_source)
 
 ACLOCAL_AMFLAGS = -I . -I .. -I ../config