| Message ID | 1409051131-7260-1-git-send-email-vvv444@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Tuesday, August 26, 2014 at 01:05:31 PM, Vasili Galka wrote: > Some drivers (e.g. net/e1000) reference these functions. So, this > fixes the build of MVBC_P board. > > I'm not familiar with the MPC5xxx platform, maybe a full > implementation shall be implemented instead of this stub in the > future. Is MPC5xxx cache coherent PPC or is it not ? > Signed-off-by: Vasili Galka <vvv444@gmail.com> > Cc: Wolfgang Denk <wd@denx.de>, Marek Vasut <marex@denx.de> +CC Scott , he can likely clarify . > --- > arch/powerpc/cpu/mpc5xxx/Makefile | 1 + > arch/powerpc/cpu/mpc5xxx/cache.c | 15 +++++++++++++++ > 2 files changed, 16 insertions(+), 0 deletions(-) > create mode 100644 arch/powerpc/cpu/mpc5xxx/cache.c > > diff --git a/arch/powerpc/cpu/mpc5xxx/Makefile > b/arch/powerpc/cpu/mpc5xxx/Makefile index 5c67e1d..d122b29 100644 > --- a/arch/powerpc/cpu/mpc5xxx/Makefile > +++ b/arch/powerpc/cpu/mpc5xxx/Makefile > @@ -7,6 +7,7 @@ > > extra-y = start.o > extra-y += traps.o > +obj-y += cache.o > obj-y += io.o > obj-y += firmware_sc_task_bestcomm.impl.o > obj-y += i2c.o > diff --git a/arch/powerpc/cpu/mpc5xxx/cache.c > b/arch/powerpc/cpu/mpc5xxx/cache.c new file mode 100644 > index 0000000..5d674bc > --- /dev/null > +++ b/arch/powerpc/cpu/mpc5xxx/cache.c > @@ -0,0 +1,15 @@ > +/* > + * This file contains stub implementation of > + * invalidate_dcache_range() > + * flush_dcache_range() > + * > + * SPDX-License-Identifier: GPL-2.0+ > + */ > + > +void invalidate_dcache_range(unsigned long start, unsigned long stop) > +{ > +} > + > +void flush_dcache_range(unsigned long start, unsigned long stop) > +{ > +} Best regards, Marek Vasut
On Tue, 2014-08-26 at 21:45 +0200, Marek Vasut wrote: > On Tuesday, August 26, 2014 at 01:05:31 PM, Vasili Galka wrote: > > Some drivers (e.g. net/e1000) reference these functions. So, this > > fixes the build of MVBC_P board. > > > > I'm not familiar with the MPC5xxx platform, maybe a full > > implementation shall be implemented instead of this stub in the > > future. > > Is MPC5xxx cache coherent PPC or is it not ? > > > Signed-off-by: Vasili Galka <vvv444@gmail.com> > > Cc: Wolfgang Denk <wd@denx.de>, Marek Vasut <marex@denx.de> > > +CC Scott , he can likely clarify . MPC5xxx is from a different part of Freescale, so I'm not sure, except to note that the first link I found by googling "mpc5xxx cache coherent" is a patch from Wolfgang suggesting that it is: https://git.linaro.org/?p=boot/u-boot-linaro-stable.git;a=patch;h=8419c013048b1f15f3fa2fc7c0463d860a04ee3e :-) -Scott
On Tuesday, August 26, 2014 at 09:48:26 PM, Scott Wood wrote: > On Tue, 2014-08-26 at 21:45 +0200, Marek Vasut wrote: > > On Tuesday, August 26, 2014 at 01:05:31 PM, Vasili Galka wrote: > > > Some drivers (e.g. net/e1000) reference these functions. So, this > > > fixes the build of MVBC_P board. > > > > > > I'm not familiar with the MPC5xxx platform, maybe a full > > > implementation shall be implemented instead of this stub in the > > > future. > > > > Is MPC5xxx cache coherent PPC or is it not ? > > > > > Signed-off-by: Vasili Galka <vvv444@gmail.com> > > > Cc: Wolfgang Denk <wd@denx.de>, Marek Vasut <marex@denx.de> > > > > +CC Scott , he can likely clarify . > > MPC5xxx is from a different part of Freescale, so I'm not sure, except > to note that the first link I found by googling "mpc5xxx cache coherent" > is a patch from Wolfgang suggesting that it is: > > https://git.linaro.org/?p=boot/u-boot-linaro-stable.git;a=patch;h=8419c0130 > 48b1f15f3fa2fc7c0463d860a04ee3e Well OK. Who shall pick this patch up or decide what to do about it ? Best regards, Marek Vasut
Dear Vasili Galka, In message <1409051131-7260-1-git-send-email-vvv444@gmail.com> you wrote: > Some drivers (e.g. net/e1000) reference these functions. So, this > fixes the build of MVBC_P board. > > I'm not familiar with the MPC5xxx platform, maybe a full > implementation shall be implemented instead of this stub in the > future. > > Signed-off-by: Vasili Galka <vvv444@gmail.com> > Cc: Wolfgang Denk <wd@denx.de>, Marek Vasut <marex@denx.de> > --- > arch/powerpc/cpu/mpc5xxx/Makefile | 1 + > arch/powerpc/cpu/mpc5xxx/cache.c | 15 +++++++++++++++ > 2 files changed, 16 insertions(+), 0 deletions(-) > create mode 100644 arch/powerpc/cpu/mpc5xxx/cache.c Acked-by: Wolfgang Denk <wd@denx.de> Tom, can you please pick this up directly? Thanks! Best regards, Wolfgang Denk
On Mon, Sep 01, 2014 at 10:53:10PM +0200, Wolfgang Denk wrote: > Dear Vasili Galka, > > In message <1409051131-7260-1-git-send-email-vvv444@gmail.com> you wrote: > > Some drivers (e.g. net/e1000) reference these functions. So, this > > fixes the build of MVBC_P board. > > > > I'm not familiar with the MPC5xxx platform, maybe a full > > implementation shall be implemented instead of this stub in the > > future. > > > > Signed-off-by: Vasili Galka <vvv444@gmail.com> > > Cc: Wolfgang Denk <wd@denx.de>, Marek Vasut <marex@denx.de> > > --- > > arch/powerpc/cpu/mpc5xxx/Makefile | 1 + > > arch/powerpc/cpu/mpc5xxx/cache.c | 15 +++++++++++++++ > > 2 files changed, 16 insertions(+), 0 deletions(-) > > create mode 100644 arch/powerpc/cpu/mpc5xxx/cache.c > > Acked-by: Wolfgang Denk <wd@denx.de> > > > Tom, can you please pick this up directly? Thanks! Applied to u-boot/master, thanks!
diff --git a/arch/powerpc/cpu/mpc5xxx/Makefile b/arch/powerpc/cpu/mpc5xxx/Makefile index 5c67e1d..d122b29 100644 --- a/arch/powerpc/cpu/mpc5xxx/Makefile +++ b/arch/powerpc/cpu/mpc5xxx/Makefile @@ -7,6 +7,7 @@ extra-y = start.o extra-y += traps.o +obj-y += cache.o obj-y += io.o obj-y += firmware_sc_task_bestcomm.impl.o obj-y += i2c.o diff --git a/arch/powerpc/cpu/mpc5xxx/cache.c b/arch/powerpc/cpu/mpc5xxx/cache.c new file mode 100644 index 0000000..5d674bc --- /dev/null +++ b/arch/powerpc/cpu/mpc5xxx/cache.c @@ -0,0 +1,15 @@ +/* + * This file contains stub implementation of + * invalidate_dcache_range() + * flush_dcache_range() + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +void invalidate_dcache_range(unsigned long start, unsigned long stop) +{ +} + +void flush_dcache_range(unsigned long start, unsigned long stop) +{ +}
Some drivers (e.g. net/e1000) reference these functions. So, this fixes the build of MVBC_P board. I'm not familiar with the MPC5xxx platform, maybe a full implementation shall be implemented instead of this stub in the future. Signed-off-by: Vasili Galka <vvv444@gmail.com> Cc: Wolfgang Denk <wd@denx.de>, Marek Vasut <marex@denx.de> --- arch/powerpc/cpu/mpc5xxx/Makefile | 1 + arch/powerpc/cpu/mpc5xxx/cache.c | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 0 deletions(-) create mode 100644 arch/powerpc/cpu/mpc5xxx/cache.c